[test][lldb-vscode] Un-realpath coreFile test.

[rupprecht]

Summary

TestVSCode_coreFile looks for an exe/core file in the same directory as the test. It first calls realpath, but I don't think it's necessary. Using realpath prevents this test from working when run as part of a build system that uses content-addressed-storage, i.e. all the files might all be symlinks in the same directory pointing to files in different directories elsewhere. If some amount of normalization is needed, maybe os.path.normpath() would be useful, although I wouldn't see why that's needed either.

(This is a fairly trivial patch, but I'm mailing it to see if there is a reason we need to keep realpath, and if so, if there's some other workaround we can do).

[wallace]

yep, there's no need for the realpath
Thanks!

lldb/test/API/tools/lldb-vscode/coreFile/TestVSCode_coreFile.py

 
 
 class TestVSCode_coreFile(lldbvscode_testcase.VSCodeTestCaseBase):
 
     @skipIfWindows
     @skipIfRemote
     @skipIfLLVMTargetMissing("X86")
     def test_core_file(self):
-        current_dir = os.path.dirname(os.path.realpath(__file__))
+        current_dir = os.path.dirname(__file__)
         exe_file = os.path.join(current_dir, "linux-x86_64.out")
         core_file = os.path.join(current_dir, "linux-x86_64.core")
 
         self.create_debug_adaptor()
         self.attach(exe_file, coreFile=core_file)
 
         expected_frames = [
             {'column': 0, 'id': 524288, 'line': 4, 'name': 'bar', 'source': {'name': 'main.c', 'path': '/home/labath/test/main.c'}},
def test_core_file(self):
         self.vscode.request_next(threadId=32259)
         self.assertEquals(self.get_stackFrames(), expected_frames)
 
     @skipIfWindows
     @skipIfRemote
     @skipIfLLVMTargetMissing("X86")
     def test_core_file_source_mapping(self):
         ''' Test that sourceMap property is correctly applied when loading a core '''
-        current_dir = os.path.dirname(os.path.realpath(__file__))
+        current_dir = os.path.dirname(__file__)
         exe_file = os.path.join(current_dir, "linux-x86_64.out")
         core_file = os.path.join(current_dir, "linux-x86_64.core")
 
         self.create_debug_adaptor()
 
         source_map = [["/home/labath/test", current_dir]]
         self.attach(exe_file, coreFile=core_file, sourceMap=source_map)
 
         self.assertTrue(current_dir in self.get_stackFrames()[0]['source']['path'])