This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Let -register-info-debug dump Offset/Size for each SubRegIndex
ClosedPublic

Authored by bjope on Nov 18 2022, 4:18 PM.

Details

Summary

This patch adds dumping of the Offset and Size info for each
SubRegIndex printed when using

llvm-tblgen -gen-register-info -register-info-debug

It also updates the ConcatenatedSubregs.td to check those printouts,
including some new subreg definitions that show short-comings in
how the size is calculated when concatenating subregisters and at
least one has an incomplete size (-1). Today TableGen will just add
sizes together, resulting in MCRegisterInfo::getSubRegIdxSize()
returning a value that isn't -1 even if the combined subregister size
is unknown.

Diff Detail

Event Timeline

bjope created this revision.Nov 18 2022, 4:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 4:18 PM
Herald added a subscriber: arphaman. · View Herald Transcript
bjope requested review of this revision.Nov 18 2022, 4:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 4:18 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm accepted this revision.Nov 18 2022, 4:22 PM

LGTM

This revision is now accepted and ready to land.Nov 18 2022, 4:22 PM
This revision was landed with ongoing or failed builds.Nov 20 2022, 11:52 AM
This revision was automatically updated to reflect the committed changes.