[libc][benchmark] Fix wrong BatchSize leading to data not fitting in L1.

[gchatelet]

libc/benchmarks/LibcMemoryBenchmark.cpp

85

The error is here. It always should have been ParameterStorageBytes but we were using BufferSize.

[courbet]

libc/benchmarks/LibcMemoryBenchmark.cpp

92

The error message is not very useful. Maybe something along the lines of:

We're splitting a buffer of the size of the L1 cache between a data buffer and a benchmark parameters buffer, so by construction the total shoul dnot exceed the size of the L1 cache

[gchatelet]

• Update error message

[gchatelet]

libc/benchmarks/LibcMemoryBenchmark.cpp

92

Much better, thx!

libc/benchmarks/LibcMemoryBenchmark.cpp

const auto IsL1DataCache = [](const CacheInfo &CI) {
     return CI.Type == "Data" && CI.Level == 1;
   };
   const auto CacheIt = find_if(CacheInfos, IsL1DataCache);
   if (CacheIt != CacheInfos.end())
     return CacheIt->Size;
   report_fatal_error("Unable to read L1 Cache Data Size");
 }
 
-static size_t getAvailableBufferSize() {
-  static constexpr int64_t KiB = 1024;
-  static constexpr int64_t ParameterStorageBytes = 4 * KiB;
-  static constexpr int64_t L1LeftAsideBytes = 1 * KiB;
+
+static size_t getAvailableBufferSize() {
   return getL1DataCacheSize() - L1LeftAsideBytes - ParameterStorageBytes;
 }
 
 ParameterBatch::ParameterBatch(size_t BufferCount)
     : BufferSize(getAvailableBufferSize() / BufferCount),
-      BatchSize(BufferSize / sizeof(ParameterType)), Parameters(BatchSize) {
+      BatchSize(ParameterStorageBytes / sizeof(ParameterType)),
+      Parameters(BatchSize) {
   if (BufferSize <= 0 || BatchSize < 100)
     report_fatal_error("Not enough L1 cache");
+  const size_t ParameterBytes = Parameters.size() * sizeof(ParameterType);
+  const size_t BufferBytes = BufferSize * BufferCount;
+  if (ParameterBytes + BufferBytes + L1LeftAsideBytes > getL1DataCacheSize())
+    report_fatal_error("Invalid state");
 }
 
 size_t ParameterBatch::getBatchBytes() const {
   size_t BatchBytes = 0;
   for (auto &P : Parameters)
     BatchBytes += P.SizeBytes;
   return BatchBytes;
 }