Page MenuHomePhabricator

Replacements in different files do not overlap.
ClosedPublic

Authored by angelgarcia on Oct 16 2015, 7:10 AM.

Details

Summary

Prevent clang-tidy from discarding fixes that are in different files but happen to have the same file offset.

Diff Detail

Repository
rL LLVM

Event Timeline

angelgarcia retitled this revision from to Replacements in different files do not overlap..
angelgarcia updated this object.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
klimek accepted this revision.Oct 16 2015, 7:16 AM
klimek edited edge metadata.

lg

This revision is now accepted and ready to land.Oct 16 2015, 7:16 AM

Is there a way to unittest this?

angelgarcia edited edge metadata.

Add a test.

bkramer accepted this revision.Oct 16 2015, 9:13 AM
bkramer added a reviewer: bkramer.

test looks good too, thanks!

angelgarcia edited edge metadata.

Use "not" instead of "!".

In both files.

This revision was automatically updated to reflect the committed changes.