This is an archive of the discontinued LLVM Phabricator instance.

[Support] Use thread safe version of getpwuid and getpwnam.
ClosedPublic

Authored by yabinc on Nov 11 2022, 1:26 PM.

Details

Summary

OpenGroup specification doesn't require getpwuid and getpwnam
to be thread-safe. And musl libc has a not thread-safe implementation.
When building clang with musl, this can make clang-scan-deps crash.

Diff Detail

Event Timeline

yabinc created this revision.Nov 11 2022, 1:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2022, 1:26 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
yabinc requested review of this revision.Nov 11 2022, 1:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2022, 1:26 PM
pirama accepted this revision.Nov 11 2022, 3:53 PM

Thanks for fixing the musl break Yabin!

This revision is now accepted and ready to land.Nov 11 2022, 3:53 PM
This revision was landed with ongoing or failed builds.Nov 14 2022, 9:49 AM
This revision was automatically updated to reflect the committed changes.