This is an archive of the discontinued LLVM Phabricator instance.

[lit] [Windows] Print exit codes > 255 as hex too
ClosedPublic

Authored by mstorsjo on Nov 10 2022, 1:41 AM.

Details

Summary

891bb4872c8098f8a851a92e989af3252b46f5ad made negative exit codes
be printed as hex, which makes it easier to recognize e.g.
0xC0000005 instead of -1073741819. However, current Python versions
(at least the ones I'm using) seem to end up with positive unsigned
return codes, so that again ends up printed as 3221225477.

Print any return code over 255 as a hexadecimal number instead.

Diff Detail

Event Timeline

mstorsjo created this revision.Nov 10 2022, 1:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2022, 1:41 AM
Herald added a subscriber: delcypher. · View Herald Transcript
mstorsjo requested review of this revision.Nov 10 2022, 1:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2022, 1:41 AM
rnk accepted this revision.Nov 14 2022, 12:12 PM

I agree, this would be super helpful.

This revision is now accepted and ready to land.Nov 14 2022, 12:12 PM
This revision was landed with ongoing or failed builds.Nov 15 2022, 2:11 AM
This revision was automatically updated to reflect the committed changes.