This is an archive of the discontinued LLVM Phabricator instance.

[include-cleaner] add macro symbols and implicit refs to HTML report
ClosedPublic

Authored by sammccall on Nov 8 2022, 4:08 PM.

Diff Detail

Event Timeline

sammccall created this revision.Nov 8 2022, 4:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2022, 4:08 PM
sammccall requested review of this revision.Nov 8 2022, 4:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2022, 4:08 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hokein accepted this revision.Nov 9 2022, 1:34 AM
hokein added inline comments.
clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
305

It seems noisy to print it even there is only one candidate, maybe exclude it if there is only one candidate?

This revision is now accepted and ready to land.Nov 9 2022, 1:34 AM
sammccall updated this revision to Diff 474738.Nov 11 2022, 6:10 AM
  • hover card follows the internal data model: symbol -> location -> header (->include, later)
  • don't use public API, so we can get at internal details
sammccall edited the summary of this revision. (Show Details)Nov 14 2022, 1:19 AM

Updated the demo link, PTAL (significant changes since last review)

The new UI looks good.

clang-tools-extra/include-cleaner/lib/Analysis.cpp
24

nit: mention the writeHTMLReport function explicitly.

clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
355

We need a special logic (if (auto SS = Recognizer(&ND)) {...}) for the stdlib symbols, otherwise, they will be treated as normal Decl symbols.

This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.