This is an archive of the discontinued LLVM Phabricator instance.

[NFC][intelpt] Improve IntelPT trace bundle documentation
ClosedPublic

Authored by jj10306 on Nov 6 2022, 2:34 PM.

Details

Summary

Mention that the LLVM/clang triple must be provided if the trace will be
consumed via SBTraceCursor

Test Plan:

Diff Detail

Event Timeline

jj10306 created this revision.Nov 6 2022, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 2:34 PM
jj10306 requested review of this revision.Nov 6 2022, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 2:34 PM
wallace added inline comments.Nov 6 2022, 2:59 PM
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
244

something along these lines is more accurate

jj10306 updated this revision to Diff 473515.Nov 6 2022, 3:36 PM

Improve docs

jj10306 marked an inline comment as done.Nov 6 2022, 3:41 PM

resolve comments

wallace added inline comments.Nov 6 2022, 3:45 PM
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
244

split this into 80-char lines, please :)

jj10306 updated this revision to Diff 473628.Nov 7 2022, 5:19 AM
jj10306 marked an inline comment as done.

address comments

lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
244

wonder why git clang-format didn't suggest this?

wallace accepted this revision.Nov 7 2022, 9:52 AM
wallace added inline comments.
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
244

I think it's because this is a special kind of string that should be taken literal

This revision is now accepted and ready to land.Nov 7 2022, 9:52 AM
This revision was automatically updated to reflect the committed changes.