Page MenuHomePhabricator

jj10306 (Jakob Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 9 2021, 8:39 AM (10 w, 2 d)

Recent Activity

Aug 13 2021

jj10306 requested review of D108050: [wip] [trace] Hierarchical Trace Representation (HTR) redesign and "call stack trace" visualization.
Aug 13 2021, 12:01 PM · Restricted Project

Aug 10 2021

jj10306 updated the diff for D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command.

lint + comments

Aug 10 2021, 7:56 AM · Restricted Project

Aug 9 2021

jj10306 added a comment to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.

A more comprehensive test for this logic was added in https://reviews.llvm.org/D107674

Aug 9 2021, 8:58 PM · Restricted Project
jj10306 updated the diff for D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command.
  • fix comment style
Aug 9 2021, 8:56 PM · Restricted Project
jj10306 updated the diff for D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command.
  • move documentation to plugin directory
  • remove unnecessary checks in tests and remove test that wasn't testing anything different than the others
  • nits
Aug 9 2021, 8:45 PM · Restricted Project

Aug 6 2021

jj10306 requested review of D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command.
Aug 6 2021, 3:42 PM · Restricted Project

Aug 3 2021

jj10306 added a comment to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.

Hey @jj10306, thanks for working on this.

@wallace @clayborg -- It seems like there are a ton of logic changes introduced in this patch that are tested at too coarse a level. I'm not confident in the changes being made here. For example, there's a bunch of subtle work being done in BasicSuperBlockMerge, but only ~one opaque high-level check that attempts to validate any of the logic: self.assertTrue(num_units_by_layer[1] == 383). Where does 383 come from? How do we know that that's the right result? If there's a bug in BasicSuperBlockMerge, would the regression test just look like changing the magic 383 number?

I'm not really comfortable with this being checked in, and would suggest a revert until some more granular unit tests can be added to the patch. (Also paging @JDevlieghere in case he has thoughts on the testing.)

Aug 3 2021, 3:21 PM · Restricted Project

Jul 27 2021

jj10306 retitled D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization from [trace] Add `thread trace export` command for Intel PT trace visualization to [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 27 2021, 10:09 AM · Restricted Project

Jul 26 2021

jj10306 updated the diff for D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.

Rebased (integrate with https://reviews.llvm.org/D106501#change-SoRRVpoqDNdx) and address comments

Jul 26 2021, 11:34 PM · Restricted Project
jj10306 added a reviewer for D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization: davidca.
Jul 26 2021, 4:02 PM · Restricted Project

Jul 24 2021

jj10306 added a comment to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.

Looks like I pulled in some unwanted changes related to the traceinstruction dumper and tsc when I rebased - will resolve this issue before landing

Jul 24 2021, 9:01 AM · Restricted Project
jj10306 updated the diff for D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.

Rebase and address comments

Jul 24 2021, 8:52 AM · Restricted Project

Jul 23 2021

jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 23 2021, 2:41 PM · Restricted Project
jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 23 2021, 10:28 AM · Restricted Project
jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 23 2021, 9:41 AM · Restricted Project

Jul 22 2021

jj10306 updated the diff for D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.

Address comments:

  • use unique_ptr to prevent unnecessary copying
  • add support for trace decoding errors
Jul 22 2021, 2:13 PM · Restricted Project
jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 22 2021, 2:10 PM · Restricted Project

Jul 21 2021

jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 21 2021, 12:03 PM · Restricted Project
jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 21 2021, 9:50 AM · Restricted Project

Jul 19 2021

jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 19 2021, 11:33 AM · Restricted Project
jj10306 updated the diff for D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
  • Add HTR documentation to lldb/docs/htr.rst
  • Change new command to thread trace export --format <format> --outfile <filename>
  • Distinguish between the instruction layer and all other layers - add IHTRLayer interface that HTRInstructionLayer and HTRBlockLayer implement
  • Remove unnecessary templates
  • Add accessor methods to HTR classes and remove all uses of friend
Jul 19 2021, 11:28 AM · Restricted Project

Jul 14 2021

jj10306 added inline comments to D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 14 2021, 4:57 PM · Restricted Project

Jul 9 2021

jj10306 requested review of D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization.
Jul 9 2021, 2:51 PM · Restricted Project