- User Since
- Jul 9 2021, 8:39 AM (64 w, 3 d)
Aug 12 2022
Aug 11 2022
Aug 2 2022
Revert changes to DecodedThread trace item getter API's
qq: Do we plan to add this kernel tracing support for live tracing as well?
- address comments
- minor changes to DecodedThread::GetInstructionLoadAddress and DecodedThread::GetErrorByIndex
Aug 1 2022
Jul 27 2022
Jul 26 2022
Remove unnecessary comment
Rebase, fix merge conflicts with D130320
remove accidentily included change to trace dumper
Jul 20 2022
Jul 19 2022
AFAICT this doesn't handle the TSCs we get for CPU change events through the context switch traces, is that correct?
This will be very useful to have for visualization purposes.
Jul 13 2022
thanks for answering those questions, lgtm
thanks for following up on those questions, lgtm
lgtm, two minor comments
looks good overall, just a couple questions from my end
looks good overall, just a couple minor suggestions and questions
Jul 12 2022
Jun 29 2022
This is awesome work - the code is much more understandable, so thanks for doing this!
Jun 28 2022
review- part 1
Thanks for fixing this!
lgtm, thanks for making the cursor traversal much cleaner
Jun 24 2022
will take a complete look over the weekend, but wanted to point out the conflict with @persona0220's diff asap
Thanks for working on this 🙂
Looks good overall, just left some minor comments.
lgtm - thanks for doing this renaming 🙂
Jun 22 2022
looks great overall, just a couple minor comments!
Jun 20 2022
rebase and use SBFileSpec constructor with that requires an explicit resolve flag before landing
Note: I changed "trace session file" to "trace description file" in the new methods, but saving the project wide rename/adoption of "trace description file" for a separate diff as to not cloud the purpose of this diff.
Jun 17 2022
Jun 15 2022
looks great overall, just a couple minor things.
Looks great overall, thanks for making these improvements - just a couple minor things
sending this back to you based on the one minor thing we discussed related to reloading. If this is addressed in one of the cleanup diffs, lmk and I'll accept this.
Jun 12 2022
Jun 9 2022
Jun 4 2022
feeback-v3 - completed review
Jun 3 2022
May 31 2022
May 27 2022
May 19 2022
Submitting my comments so far, will continue my review in a bit
May 17 2022
May 11 2022
couple minor things, but looks good overall