Page MenuHomePhabricator

jj10306 (Jakob Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 9 2021, 8:39 AM (64 w, 3 d)

Recent Activity

Aug 12 2022

jj10306 accepted D131630: [trace][intel pt] Fix per-psb packet decoding.
Aug 12 2022, 2:46 PM · Restricted Project, Restricted Project

Aug 11 2022

jj10306 requested changes to D131630: [trace][intel pt] Fix per-psb packet decoding.
Aug 11 2022, 12:17 PM · Restricted Project, Restricted Project

Aug 2 2022

jj10306 committed rGf9b4ea0ce9ef: [trace] Add SBTraceCursor bindings (authored by jj10306).
[trace] Add SBTraceCursor bindings
Aug 2 2022, 4:56 PM · Restricted Project
jj10306 closed D130930: [trace] Add SBTraceCursor bindings.
Aug 2 2022, 4:55 PM · Restricted Project, Restricted Project
jj10306 committed rG6cbc6e9a6d5f: [LLDB] Add SBInstruction::GetControlFlowKind() (authored by jj10306).
[LLDB] Add SBInstruction::GetControlFlowKind()
Aug 2 2022, 3:50 PM · Restricted Project
jj10306 closed D131005: [LLDB] Add SBInstruction::GetControlFlowKind().
Aug 2 2022, 3:50 PM · Restricted Project, Restricted Project
jj10306 updated the diff for D130930: [trace] Add SBTraceCursor bindings.

nit

Aug 2 2022, 3:39 PM · Restricted Project, Restricted Project
jj10306 updated the diff for D130930: [trace] Add SBTraceCursor bindings.

Revert changes to DecodedThread trace item getter API's

Aug 2 2022, 3:31 PM · Restricted Project, Restricted Project
jj10306 requested review of D131005: [LLDB] Add SBInstruction::GetControlFlowKind().
Aug 2 2022, 11:39 AM · Restricted Project, Restricted Project
jj10306 added inline comments to D130930: [trace] Add SBTraceCursor bindings.
Aug 2 2022, 8:52 AM · Restricted Project, Restricted Project
jj10306 requested changes to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.

Nice work!
qq: Do we plan to add this kernel tracing support for live tracing as well?

Aug 2 2022, 8:51 AM · Restricted Project, Restricted Project
jj10306 updated the diff for D130930: [trace] Add SBTraceCursor bindings.
  1. address comments
  2. rebase
  3. minor changes to DecodedThread::GetInstructionLoadAddress and DecodedThread::GetErrorByIndex
Aug 2 2022, 7:30 AM · Restricted Project, Restricted Project
jj10306 added inline comments to D130930: [trace] Add SBTraceCursor bindings.
Aug 2 2022, 7:30 AM · Restricted Project, Restricted Project

Aug 1 2022

jj10306 committed rG3bec33b16db1: [trace] Replace TraceCursorUP with TraceCursorSP (authored by jj10306).
[trace] Replace TraceCursorUP with TraceCursorSP
Aug 1 2022, 1:54 PM · Restricted Project
jj10306 closed D130925: [trace] Replace TraceCursorUP with TraceCursorSP.
Aug 1 2022, 1:54 PM · Restricted Project, Restricted Project
jj10306 requested review of D130930: [trace] Add SBTraceCursor bindings.
Aug 1 2022, 12:43 PM · Restricted Project, Restricted Project
jj10306 committed rG9bab358e3922: [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API… (authored by jj10306).
[trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API…
Aug 1 2022, 11:53 AM · Restricted Project
jj10306 closed D130924: [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes.
Aug 1 2022, 11:52 AM · Restricted Project, Restricted Project
jj10306 updated the summary of D130925: [trace] Replace TraceCursorUP with TraceCursorSP.
Aug 1 2022, 11:50 AM · Restricted Project, Restricted Project
jj10306 requested review of D130925: [trace] Replace TraceCursorUP with TraceCursorSP.
Aug 1 2022, 11:50 AM · Restricted Project, Restricted Project
jj10306 retitled D130924: [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes from [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes to [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes.
Aug 1 2022, 11:48 AM · Restricted Project, Restricted Project
jj10306 requested review of D130924: [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes.
Aug 1 2022, 11:47 AM · Restricted Project, Restricted Project

Jul 27 2022

jj10306 committed rGdde3cf2e83d2: [trace] Add instruction control flow kind to JSON trace dumper's output (authored by jj10306).
[trace] Add instruction control flow kind to JSON trace dumper's output
Jul 27 2022, 5:25 AM · Restricted Project
jj10306 closed D130607: [trace] Add instruction control flow kind to JSON trace dumper's output.
Jul 27 2022, 5:24 AM · Restricted Project, Restricted Project

Jul 26 2022

jj10306 requested review of D130607: [trace] Add instruction control flow kind to JSON trace dumper's output.
Jul 26 2022, 4:26 PM · Restricted Project, Restricted Project
jj10306 committed rGd36ae4952d70: Add string conversion for InstructionControlFlowKind enum (authored by jj10306).
Add string conversion for InstructionControlFlowKind enum
Jul 26 2022, 4:10 PM · Restricted Project
jj10306 closed D130580: Refactor string conversion for InstructionControlFlowKind enum.
Jul 26 2022, 4:10 PM · Restricted Project, Restricted Project
jj10306 updated the diff for D130580: Refactor string conversion for InstructionControlFlowKind enum.

Remove unnecessary comment

Jul 26 2022, 12:44 PM · Restricted Project, Restricted Project
jj10306 updated the diff for D130580: Refactor string conversion for InstructionControlFlowKind enum.

Rebase, fix merge conflicts with D130320

Jul 26 2022, 12:40 PM · Restricted Project, Restricted Project
jj10306 added inline comments to D130580: Refactor string conversion for InstructionControlFlowKind enum.
Jul 26 2022, 8:57 AM · Restricted Project, Restricted Project
jj10306 retitled D130580: Refactor string conversion for InstructionControlFlowKind enum from Add string conversion for InstructionControlFlowKind enum to Refactor string conversion for InstructionControlFlowKind enum.
Jul 26 2022, 8:53 AM · Restricted Project, Restricted Project
jj10306 added inline comments to D130580: Refactor string conversion for InstructionControlFlowKind enum.
Jul 26 2022, 8:50 AM · Restricted Project, Restricted Project
jj10306 updated the diff for D130580: Refactor string conversion for InstructionControlFlowKind enum.

remove accidentily included change to trace dumper

Jul 26 2022, 8:50 AM · Restricted Project, Restricted Project
jj10306 requested review of D130580: Refactor string conversion for InstructionControlFlowKind enum.
Jul 26 2022, 8:36 AM · Restricted Project, Restricted Project

Jul 20 2022

jj10306 requested changes to D130054: [trace][intel pt] Introduce wall clock time for each trace item.
Jul 20 2022, 7:32 AM · Restricted Project, Restricted Project

Jul 19 2022

jj10306 added a comment to D130054: [trace][intel pt] Introduce wall clock time for each trace item.

AFAICT this doesn't handle the TSCs we get for CPU change events through the context switch traces, is that correct?
This will be very useful to have for visualization purposes.

Jul 19 2022, 8:14 AM · Restricted Project, Restricted Project
jj10306 requested changes to D130054: [trace][intel pt] Introduce wall clock time for each trace item.
Jul 19 2022, 8:04 AM · Restricted Project, Restricted Project

Jul 13 2022

jj10306 accepted D129257: [trace][intel pt] Add a cgroup filter.

thanks for answering those questions, lgtm

Jul 13 2022, 12:25 PM · Restricted Project, Restricted Project
jj10306 accepted D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper.

thanks for following up on those questions, lgtm

Jul 13 2022, 12:21 PM · Restricted Project, Restricted Project
jj10306 accepted D129249: [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode.

lgtm

Jul 13 2022, 8:56 AM · Restricted Project, Restricted Project
jj10306 accepted D129613: [trace][intel pt] Add a nice parser for the trace size.
Jul 13 2022, 8:54 AM · Restricted Project, Restricted Project
jj10306 accepted D129332: [trace][intel pt] Support dumping the trace info in json.
Jul 13 2022, 8:45 AM · Restricted Project, Restricted Project
jj10306 accepted D129239: [trace] Add an option to save a compact trace bundle.

lgtm, two minor comments

Jul 13 2022, 8:37 AM · Restricted Project, Restricted Project
jj10306 requested changes to D129257: [trace][intel pt] Add a cgroup filter.

looks good overall, just a couple questions from my end

Jul 13 2022, 8:15 AM · Restricted Project, Restricted Project
jj10306 requested changes to D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper.

looks good overall, just a couple minor suggestions and questions

Jul 13 2022, 7:35 AM · Restricted Project, Restricted Project

Jul 12 2022

jj10306 accepted D129588: [trace] Avoid a crash in the dumper when disassembling fails.
Jul 12 2022, 1:30 PM · Restricted Project, Restricted Project

Jun 29 2022

jj10306 accepted D128576: [trace] Make events first class items in the trace cursor and rework errors.

This is awesome work - the code is much more understandable, so thanks for doing this!

Jun 29 2022, 6:00 AM · Restricted Project, Restricted Project

Jun 28 2022

jj10306 requested changes to D128576: [trace] Make events first class items in the trace cursor and rework errors.

review- part 1

Jun 28 2022, 9:31 AM · Restricted Project, Restricted Project
jj10306 accepted D128707: [lldb] Fix build on older Linux kernel versions.

Thanks for fixing this!

Jun 28 2022, 5:13 AM · Restricted Project, Restricted Project
jj10306 accepted D128543: [trace] Improve the TraceCursor iteration API.

lgtm, thanks for making the cursor traversal much cleaner

Jun 28 2022, 4:52 AM · Restricted Project, Restricted Project

Jun 24 2022

jj10306 requested changes to D128543: [trace] Improve the TraceCursor iteration API.

will take a complete look over the weekend, but wanted to point out the conflict with @persona0220's diff asap

Jun 24 2022, 3:19 PM · Restricted Project, Restricted Project
jj10306 requested changes to D128477: [trace] Add a flag to the decoder to output the instruction type.

Thanks for working on this 🙂
Looks good overall, just left some minor comments.

Jun 24 2022, 7:03 AM · Restricted Project, Restricted Project
jj10306 accepted D128484: [NFC][lldb][trace] Rename trace session to trace bundle.

lgtm - thanks for doing this renaming 🙂

Jun 24 2022, 6:10 AM · Restricted Project, Restricted Project

Jun 22 2022

jj10306 accepted D128316: [trace] Add an option to dump instructions in json and to a file.
Jun 22 2022, 10:17 AM · Restricted Project, Restricted Project
jj10306 requested changes to D128316: [trace] Add an option to dump instructions in json and to a file.

looks great overall, just a couple minor comments!

Jun 22 2022, 6:08 AM · Restricted Project, Restricted Project

Jun 20 2022

jj10306 committed rG50f936796072: Add LoadTraceFromFile to SBDebugger and SBTrace (authored by jj10306).
Add LoadTraceFromFile to SBDebugger and SBTrace
Jun 20 2022, 12:06 PM · Restricted Project
jj10306 closed D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.
Jun 20 2022, 12:06 PM · Restricted Project, Restricted Project
jj10306 added inline comments to D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.
Jun 20 2022, 11:29 AM · Restricted Project, Restricted Project
jj10306 updated the diff for D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.

rebase and use SBFileSpec constructor with that requires an explicit resolve flag before landing

Jun 20 2022, 11:28 AM · Restricted Project, Restricted Project
jj10306 added inline comments to D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.
Jun 20 2022, 8:00 AM · Restricted Project, Restricted Project
jj10306 updated the diff for D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.

Address comments
Note: I changed "trace session file" to "trace description file" in the new methods, but saving the project wide rename/adoption of "trace description file" for a separate diff as to not cloud the purpose of this diff.

Jun 20 2022, 7:53 AM · Restricted Project, Restricted Project

Jun 17 2022

jj10306 retitled D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace from Add LoadTraceFromFile to SBDebugger and SBTrace to [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.
Jun 17 2022, 4:23 PM · Restricted Project, Restricted Project
jj10306 updated the summary of D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.
Jun 17 2022, 4:23 PM · Restricted Project, Restricted Project
jj10306 requested review of D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace.
Jun 17 2022, 4:21 PM · Restricted Project, Restricted Project

Jun 15 2022

jj10306 accepted D127881: [trace][intelpt] Support system-wide tracing [22] - Some final touches.
Jun 15 2022, 12:55 PM · Restricted Project, Restricted Project
jj10306 accepted D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements.
Jun 15 2022, 12:50 PM · Restricted Project, Restricted Project
jj10306 accepted D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements.
Jun 15 2022, 10:44 AM · Restricted Project, Restricted Project
jj10306 abandoned D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces.
Jun 15 2022, 10:16 AM · Restricted Project, Restricted Project
jj10306 accepted D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON.
Jun 15 2022, 10:15 AM · Restricted Project, Restricted Project
jj10306 accepted D127817: [trace][intelpt] Support system-wide tracing [20] - Rename some fields in the schema.
Jun 15 2022, 10:10 AM · Restricted Project, Restricted Project
jj10306 accepted D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements.
Jun 15 2022, 10:06 AM · Restricted Project, Restricted Project
jj10306 requested changes to D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements.

looks great overall, just a couple minor things.

Jun 15 2022, 9:53 AM · Restricted Project, Restricted Project
jj10306 accepted D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case.
Jun 15 2022, 9:36 AM · Restricted Project, Restricted Project
jj10306 accepted D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu.
Jun 15 2022, 9:36 AM · Restricted Project, Restricted Project
jj10306 accepted D126267: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding.
Jun 15 2022, 9:35 AM · Restricted Project, Restricted Project
jj10306 accepted D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save.
Jun 15 2022, 9:35 AM · Restricted Project, Restricted Project, Restricted Project
jj10306 accepted D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server..
Jun 15 2022, 9:34 AM · Restricted Project, Restricted Project
jj10306 accepted D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces.
Jun 15 2022, 9:34 AM · Restricted Project, Restricted Project
jj10306 accepted D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration.
Jun 15 2022, 9:34 AM · Restricted Project, Restricted Project
jj10306 accepted D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class.
Jun 15 2022, 9:33 AM · Restricted Project, Restricted Project
jj10306 requested changes to D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements.

Looks great overall, thanks for making these improvements - just a couple minor things

Jun 15 2022, 9:32 AM · Restricted Project, Restricted Project
jj10306 requested changes to D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server..

sending this back to you based on the one minor thing we discussed related to reloading. If this is addressed in one of the cleanup diffs, lmk and I'll accept this.

Jun 15 2022, 9:04 AM · Restricted Project, Restricted Project

Jun 12 2022

jj10306 requested changes to D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu.
Jun 12 2022, 12:22 PM · Restricted Project, Restricted Project

Jun 9 2022

jj10306 requested changes to D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case.
Jun 9 2022, 4:48 AM · Restricted Project, Restricted Project
jj10306 accepted D126990: [trace][intelpt] Support system-wide tracing [15] - Make triple optional.
Jun 9 2022, 4:19 AM · Restricted Project, Restricted Project

Jun 4 2022

jj10306 added a comment to D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save.

feeback-v3 - completed review

Jun 4 2022, 1:30 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

jj10306 added a comment to D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save.

feedback-v2

Jun 3 2022, 1:05 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

jj10306 requested changes to D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save.

feedback-v1

May 31 2022, 6:28 PM · Restricted Project, Restricted Project, Restricted Project
jj10306 accepted D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.

lgtm

May 31 2022, 5:37 PM · Restricted Project, Restricted Project

May 27 2022

jj10306 added inline comments to D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server..
May 27 2022, 12:45 PM · Restricted Project, Restricted Project
jj10306 requested changes to D126267: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding.
May 27 2022, 12:36 PM · Restricted Project, Restricted Project

May 19 2022

jj10306 added inline comments to D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces.
May 19 2022, 6:43 PM · Restricted Project, Restricted Project
jj10306 requested changes to D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces.

Submitting my comments so far, will continue my review in a bit

May 19 2022, 8:57 AM · Restricted Project, Restricted Project
jj10306 requested changes to D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration.
May 19 2022, 8:14 AM · Restricted Project, Restricted Project
jj10306 requested changes to D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class.
May 19 2022, 8:08 AM · Restricted Project, Restricted Project

May 17 2022

jj10306 accepted D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state.
May 17 2022, 11:41 AM · Restricted Project, Restricted Project

May 11 2022

jj10306 accepted D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor.
May 11 2022, 5:26 AM · Restricted Project, Restricted Project
jj10306 added inline comments to D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.
May 11 2022, 5:11 AM · Restricted Project, Restricted Project
jj10306 accepted D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

couple minor things, but looks good overall

May 11 2022, 4:53 AM · Restricted Project, Restricted Project

May 10 2022

jj10306 added inline comments to D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state.
May 10 2022, 9:33 AM · Restricted Project, Restricted Project