This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Defer formatting of operator< to honor paren spacing
ClosedPublic

Authored by rymiel on Nov 4 2022, 5:31 PM.

Details

Summary

I'm not exactly sure what the intent of that section of
spaceRequiredBetween is doing, it seems to handle templates and <<,
but the part which adds spaces before parens is way later, as part
of spaceRequiredBeforeParens.

Fixes https://github.com/llvm/llvm-project/issues/58821

Diff Detail

Event Timeline

rymiel created this revision.Nov 4 2022, 5:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 5:31 PM
rymiel requested review of this revision.Nov 4 2022, 5:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 5:31 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rymiel added a project: Restricted Project.Nov 4 2022, 5:31 PM
owenpan accepted this revision.Nov 6 2022, 2:03 AM
owenpan added inline comments.
clang/unittests/Format/FormatTest.cpp
15548

Drop it as it doesn't test the patch?

This revision is now accepted and ready to land.Nov 6 2022, 2:03 AM
MyDeveloperDay accepted this revision.Nov 16 2022, 3:33 PM
This revision was landed with ongoing or failed builds.Nov 17 2022, 1:39 AM
This revision was automatically updated to reflect the committed changes.