This is an archive of the discontinued LLVM Phabricator instance.

Differential D137354

[scudo] Extend basic test to cover zero size allocs.
ClosedPublic

Authored by eugenis on Nov 3 2022, 1:25 PM.

Details

Reviewers
pcc
Commits
rG48dbf353025d: [scudo] Extend basic test to cover zero size allocs.

Diff Detail

Event Timeline

eugenis created this revision.Nov 3 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 1:25 PM
Herald added subscribers: Enna1, cryptoad. · View Herald Transcript
eugenis requested review of this revision.Nov 3 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 1:25 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B195989: Diff 473016.Nov 3 2022, 1:45 PM
eugenis added a comment.Nov 10 2022, 10:49 AM

ping

pcc accepted this revision.Nov 10 2022, 11:08 AM

LGTM

This revision is now accepted and ready to land.Nov 10 2022, 11:08 AM
Closed by commit rG48dbf353025d: [scudo] Extend basic test to cover zero size allocs. (authored by eugenis). · Explain WhyNov 17 2022, 11:28 AM
This revision was automatically updated to reflect the committed changes.
eugenis added a commit: rG48dbf353025d: [scudo] Extend basic test to cover zero size allocs..

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
tests/
2 lines

Diff 476193

compiler-rt/lib/scudo/standalone/tests/combined_test.cpp

Show First 20 Lines • Show All 147 Lines • ▼ Show 20 Linesvoid ScudoCombinedTest<Config>::BasicTest(scudo::uptr SizeLog) {
auto *Allocator = this->Allocator.get(); auto *Allocator = this->Allocator.get();
// This allocates and deallocates a bunch of chunks, with a wide range of // This allocates and deallocates a bunch of chunks, with a wide range of
// sizes and alignments, with a focus on sizes that could trigger weird // sizes and alignments, with a focus on sizes that could trigger weird
// behaviors (plus or minus a small delta of a power of two for example). // behaviors (plus or minus a small delta of a power of two for example).
for (scudo::uptr AlignLog = MinAlignLog; AlignLog <= 16U; AlignLog++) { for (scudo::uptr AlignLog = MinAlignLog; AlignLog <= 16U; AlignLog++) {
const scudo::uptr Align = 1U << AlignLog; const scudo::uptr Align = 1U << AlignLog;
for (scudo::sptr Delta = -32; Delta <= 32; Delta++) { for (scudo::sptr Delta = -32; Delta <= 32; Delta++) {
if (static_cast<scudo::sptr>(1U << SizeLog) + Delta <= 0) if (static_cast<scudo::sptr>(1U << SizeLog) + Delta < 0)
continue; continue;
const scudo::uptr Size = (1U << SizeLog) + Delta; const scudo::uptr Size = (1U << SizeLog) + Delta;
void *P = Allocator->allocate(Size, Origin, Align); void *P = Allocator->allocate(Size, Origin, Align);
EXPECT_NE(P, nullptr); EXPECT_NE(P, nullptr);
EXPECT_TRUE(Allocator->isOwned(P)); EXPECT_TRUE(Allocator->isOwned(P));
EXPECT_TRUE(scudo::isAligned(reinterpret_cast<scudo::uptr>(P), Align)); EXPECT_TRUE(scudo::isAligned(reinterpret_cast<scudo::uptr>(P), Align));
EXPECT_LE(Size, Allocator->getUsableSize(P)); EXPECT_LE(Size, Allocator->getUsableSize(P));
memset(P, 0xaa, Size); memset(P, 0xaa, Size);
▲ Show 20 Lines • Show All 569 Lines • Show Last 20 Lines