This adds an incomplete version where the specializations for the
format_kinds are disabled dummy formatters.
Implements part of
- P2585R0 Improving default container formatting
Paths
| Differential D137271
[libc++][format] Adds range-default-formatter. ClosedPublic Authored by Mordante on Nov 2 2022, 10:17 AM.
Details
Summary This adds an incomplete version where the specializations for the Implements part of
Diff Detail
Unit TestsFailed Event Timeline
Comment Actions Thanks for the review!
Comment Actions Looks pretty good to me, just a few comments.
This revision is now accepted and ready to land.Dec 6 2022, 9:23 AM Comment Actions Thanks for the review!
Mordante marked 3 inline comments as done. Comment ActionsRebased and address review comments. This revision was landed with ongoing or failed builds.Dec 7 2022, 8:33 AM Closed by commit rGd184958bad5c: [libc++][format] Adds range-default-formatter. (authored by Mordante). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 473423 libcxx/include/CMakeLists.txt
libcxx/include/__format/concepts.h
libcxx/include/__format/range_default_formatter.h
libcxx/include/__type_traits/is_specialization.h
libcxx/include/format
libcxx/include/module.modulemap.in
libcxx/include/type_traits
libcxx/test/libcxx/private_headers.verify.cpp
libcxx/test/libcxx/type_traits/is_specialization.compile.pass.cpp
libcxx/test/libcxx/type_traits/is_specialization.verify.cpp
libcxx/test/std/utilities/format/format.range/format.range.fmtkind/format_kind.compile.pass.cpp
libcxx/test/std/utilities/format/format.range/format.range.fmtkind/format_kind.verify.cpp
libcxx/test/std/utilities/format/format.range/format.range.fmtkind/range_format.compile.pass.cpp
|
Thanks for adding this comment! I would suggest linking to the section of the standard that defines that concept instead of the paper.