This is an archive of the discontinued LLVM Phabricator instance.

Differential D137267

[clang][Headers] Only define FLT_EVAL_METHOD for C99 and later
ClosedPublic

Authored by zatrazz on Nov 2 2022, 10:03 AM.

Details

Reviewers
jfb
eli.friedman
MaskRay
Commits
rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later
Summary

It was reported by glibc conform test [1].

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=conform/data/float.h-data;h=7b98fc03447b8918da4a0cf47d41fb3e17f4f791;hb=HEAD

Diff Detail

Event Timeline

zatrazz created this revision.Nov 2 2022, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 10:03 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
zatrazz requested review of this revision.Nov 2 2022, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 10:03 AM
Harbormaster completed remote builds in B195739: Diff 472665.Nov 2 2022, 10:51 AM
MaskRay accepted this revision.EditedNov 5 2022, 1:26 PM

Thanks! C99 and C++11 look good and the new behavior matches GCC.

[clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

Mention C++11?

This revision is now accepted and ready to land.Nov 5 2022, 1:26 PM
Closed by commit rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later (authored by zatrazz). · Explain WhyNov 8 2022, 8:59 AM
This revision was automatically updated to reflect the committed changes.
zatrazz added a commit: rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later.

Revision Contents

PathSize
clang/
lib/
Headers/
3 lines

Diff 474023

clang/lib/Headers/float.h

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
# undef FLT_HAS_SUBNORM # undef FLT_HAS_SUBNORM
# undef DBL_HAS_SUBNORM # undef DBL_HAS_SUBNORM
# undef LDBL_HAS_SUBNORM # undef LDBL_HAS_SUBNORM
# endif # endif
#endif #endif
/* Characteristics of floating point types, C99 5.2.4.2.2 */ /* Characteristics of floating point types, C99 5.2.4.2.2 */
#if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \
(defined(__cplusplus) && __cplusplus >= 201103L)
#define FLT_EVAL_METHOD __FLT_EVAL_METHOD__ #define FLT_EVAL_METHOD __FLT_EVAL_METHOD__
#endif
#define FLT_ROUNDS (__builtin_flt_rounds()) #define FLT_ROUNDS (__builtin_flt_rounds())
#define FLT_RADIX __FLT_RADIX__ #define FLT_RADIX __FLT_RADIX__
#define FLT_MANT_DIG __FLT_MANT_DIG__ #define FLT_MANT_DIG __FLT_MANT_DIG__
#define DBL_MANT_DIG __DBL_MANT_DIG__ #define DBL_MANT_DIG __DBL_MANT_DIG__
#define LDBL_MANT_DIG __LDBL_MANT_DIG__ #define LDBL_MANT_DIG __LDBL_MANT_DIG__
#if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \ #if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines