This is an archive of the discontinued LLVM Phabricator instance.

Differential D137265

[ASAN] Removed special case controlling allocator constants for __aarch64__.
ClosedPublic

Authored by kstoimenov on Nov 2 2022, 9:15 AM.

Details

Reviewers
vitalybuka
Commits
rGa8604f2254f6: [ASAN] Removed special case controlling allocator constants for __aarch64__.
Summary

This patch should land before D137136 to make sure that the leak sanitizer allocator works correctly. This patch is NFC without D137136.

Diff Detail

Unit TestsFailed

TimeTest
2,040 msx64 debian > MemProfiler-x86_64-linux.TestCases::test_merge_mib.cpp

Event Timeline

kstoimenov created this revision.Nov 2 2022, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 9:15 AM
Herald added subscribers: Enna1, kristof.beyls. · View Herald Transcript
kstoimenov requested review of this revision.Nov 2 2022, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 9:15 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov added a child revision: D137136: [Sanitizers] Modified __aarch64__ to use the 64 bit version of the allocator..Nov 2 2022, 9:18 AM
kstoimenov edited the summary of this revision. (Show Details)Nov 2 2022, 9:21 AM
kstoimenov added a reviewer: vitalybuka.
Harbormaster completed remote builds in B195728: Diff 472644.Nov 2 2022, 9:44 AM
vitalybuka added a comment.Nov 2 2022, 10:16 AM

Please include that this patch is NFC as without D137136 SANITIZER_CAN_USE_ALLOCATOR64 is 0

vitalybuka accepted this revision.Nov 2 2022, 10:17 AM

into description and git commit
note that editing description here does not update the stuff which will be in git commit

This revision is now accepted and ready to land.Nov 2 2022, 10:17 AM
kstoimenov updated this revision to Diff 472675.Nov 2 2022, 10:24 AM
kstoimenov retitled this revision from [ASAN] Removed special case controlling allocator constants for __aarch64__. to [ASAN] Removed special case controlling allocator constants for __aarch64__. This patch is NFC without D137136..

Updated description.

kstoimenov updated this revision to Diff 472676.Nov 2 2022, 10:26 AM
kstoimenov retitled this revision from [ASAN] Removed special case controlling allocator constants for __aarch64__. This patch is NFC without D137136. to [ASAN] Removed special case controlling allocator constants for __aarch64__..
kstoimenov edited the summary of this revision. (Show Details)

Moved NFC comment to the summary.

This revision was landed with ongoing or failed builds.Nov 2 2022, 10:28 AM
Closed by commit rGa8604f2254f6: [ASAN] Removed special case controlling allocator constants for __aarch64__. (authored by kstoimenov). · Explain Why
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rGa8604f2254f6: [ASAN] Removed special case controlling allocator constants for __aarch64__..
Harbormaster completed remote builds in B195748: Diff 472676.Nov 2 2022, 10:49 AM

Revision Contents

PathSize
compiler-rt/
lib/
asan/
6 lines

Diff 472676

compiler-rt/lib/asan/asan_allocator.h

Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Lines
// Android needs to support 39, 42 and 48 bit VMA. // Android needs to support 39, 42 and 48 bit VMA.
const uptr kAllocatorSpace = ~(uptr)0; const uptr kAllocatorSpace = ~(uptr)0;
const uptr kAllocatorSize = 0x2000000000ULL; // 128G. const uptr kAllocatorSize = 0x2000000000ULL; // 128G.
typedef VeryCompactSizeClassMap SizeClassMap; typedef VeryCompactSizeClassMap SizeClassMap;
#elif SANITIZER_RISCV64 #elif SANITIZER_RISCV64
const uptr kAllocatorSpace = ~(uptr)0; const uptr kAllocatorSpace = ~(uptr)0;
const uptr kAllocatorSize = 0x2000000000ULL; // 128G. const uptr kAllocatorSize = 0x2000000000ULL; // 128G.
typedef VeryDenseSizeClassMap SizeClassMap; typedef VeryDenseSizeClassMap SizeClassMap;
# elif defined(__aarch64__)
// AArch64/SANITIZER_CAN_USE_ALLOCATOR64 is only for 42-bit VMA
// so no need to different values for different VMA.
const uptr kAllocatorSpace = 0x10000000000ULL;
const uptr kAllocatorSize = 0x10000000000ULL; // 3T.
typedef DefaultSizeClassMap SizeClassMap;
#elif defined(__sparc__) #elif defined(__sparc__)
const uptr kAllocatorSpace = ~(uptr)0; const uptr kAllocatorSpace = ~(uptr)0;
const uptr kAllocatorSize = 0x20000000000ULL; // 2T. const uptr kAllocatorSize = 0x20000000000ULL; // 2T.
typedef DefaultSizeClassMap SizeClassMap; typedef DefaultSizeClassMap SizeClassMap;
# elif SANITIZER_WINDOWS # elif SANITIZER_WINDOWS
const uptr kAllocatorSpace = ~(uptr)0; const uptr kAllocatorSpace = ~(uptr)0;
const uptr kAllocatorSize = 0x8000000000ULL; // 500G const uptr kAllocatorSize = 0x8000000000ULL; // 500G
typedef DefaultSizeClassMap SizeClassMap; typedef DefaultSizeClassMap SizeClassMap;
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines