This is an archive of the discontinued LLVM Phabricator instance.

[X86] Use default attributes for more intrinsics
ClosedPublic

Authored by nikic on Nov 2 2022, 6:17 AM.

Details

Summary

Another followup to D136939, adding default attributes to the remaining readnone intrinsics.

This also covers some non-readnone pmovqw*mem_mask style intrinsics, because those were interleaved, and it seemed to make more sense to update them at the same time.

Diff Detail

Event Timeline

nikic created this revision.Nov 2 2022, 6:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 6:17 AM
nikic requested review of this revision.Nov 2 2022, 6:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 6:17 AM
pengfei added inline comments.Nov 2 2022, 8:21 PM
llvm/include/llvm/IR/IntrinsicsX86.td
5406–5429

These should be changed too.

nikic updated this revision to Diff 472868.Nov 3 2022, 1:26 AM
nikic marked an inline comment as done.

Add default attrs to more AMX intrinsics.

pengfei accepted this revision.Nov 3 2022, 5:51 AM
pengfei added a subscriber: yubing.

LGTM.

llvm/include/llvm/IR/IntrinsicsX86.td
5402–5406

Actually, only this single one is AMX intrinsic. We do need a comment for the following ones. I'll do it later.
It is reasonable to take care of AMX intrinsic, so I have excluded this one in the comments :)
I think it's OK to leave it the same as other AMX intrinsics. @yubing any suggestions for these AMX intrinsics?

This revision is now accepted and ready to land.Nov 3 2022, 5:51 AM
This revision was landed with ongoing or failed builds.Nov 4 2022, 1:42 AM
This revision was automatically updated to reflect the committed changes.