[lldb/Interpreter] Open saved transcript in GUI Editor

[mib]

Summary

This patch will automatically open LLDB's saved transcript file on the
graphical editor if lldb is running under an interactive graphical session.

This can be controlled by a new setting: interpreter.open-transcript-in-editor

rdar://92692106

Signed-off-by: Med Ismail Bennani <[e-mail]>

[JDevlieghere]

Should this be controllable with a setting? I'm not sure I (always) want my editor to pop up when I save a transcript.

lldb/source/Interpreter/CommandInterpreter.cpp

3232

If we want to report the error we should should use AppendErrorMessage and return false, but personally I don't think this warrants failing the command for and I would just fail silently.

[mib]

Address @JDevlieghere comments

[JDevlieghere]

LGTM!

[kastiglione]

looks good

lldb/source/Interpreter/CommandInterpreter.cpp

bool CommandInterpreter::SaveTranscript(
   if (error.Fail() || byte_size != m_transcript_stream.GetSize())
     return error_out("Unable to write to destination file",
                      "Bytes written do not match transcript size.");
 
   result.SetStatus(eReturnStatusSuccessFinishNoResult);
   result.AppendMessageWithFormat("Session's transcripts saved to %s\n",
                                  output_file->c_str());
 
+  if (Host::IsInteractiveGraphicSession()) {
+    const FileSpec file_spec;
+    error = file->GetFileSpec(const_cast<FileSpec &>(file_spec));
+    if (error.Success())
+      if (!Host::OpenFileInExternalEditor(file_spec, 1))
+        result.AppendMessage("Unable to open file in external editor\n");
+  }
+
   return true;
 }
 
 bool CommandInterpreter::IsInteractive() {
   return (GetIOHandler() ? GetIOHandler()->GetIsInteractive() : false);
 }
 
 FileSpec CommandInterpreter::GetCurrentSourceDir() {