This is an archive of the discontinued LLVM Phabricator instance.

Differential D137134

[libc++][Android] XFAIL aligned_alloc and timespec_get tests
ClosedPublic

Authored by rprichard on Oct 31 2022, 4:10 PM.

Details

Reviewers
ldionne
danalbert
Group Reviewers
Restricted Project
Commits
rGcdde2706cf4a: [libc++][Android] XFAIL aligned_alloc and timespec_get tests
Summary

Mark tests XFAIL that use APIs that are unsupported on old versions of
Android:

  • aligned_alloc isn't available until API 28.
  • timespec_get isn't available until API 29.

Diff Detail

Event Timeline

rprichard created this revision.Oct 31 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 4:10 PM
Herald added a subscriber: danielkiss. · View Herald Transcript
rprichard requested review of this revision.Oct 31 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 4:10 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B195387: Diff 472176.Oct 31 2022, 10:14 PM
ldionne accepted this revision.Nov 1 2022, 8:59 AM
This revision is now accepted and ready to land.Nov 1 2022, 8:59 AM
Closed by commit rGcdde2706cf4a: [libc++][Android] XFAIL aligned_alloc and timespec_get tests (authored by rprichard). · Explain WhyNov 2 2022, 2:55 PM
This revision was automatically updated to reflect the committed changes.
rprichard added a commit: rGcdde2706cf4a: [libc++][Android] XFAIL aligned_alloc and timespec_get tests.

Revision Contents

PathSize
libcxx/
test/
std/
depr/
depr.c.headers/
3 lines
language.support/
support.runtime/
3 lines
3 lines

Diff 472779

libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp

Show All 12 Lines
// ::aligned_alloc is provided by the C library, but it's marked as unavailable // ::aligned_alloc is provided by the C library, but it's marked as unavailable
// until macOS 10.15 // until macOS 10.15
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}} // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
// ::aligned_alloc is not implemented on Windows // ::aligned_alloc is not implemented on Windows
// XFAIL: target={{.+}}-windows-{{.+}} // XFAIL: target={{.+}}-windows-{{.+}}
// ::aligned_alloc is available starting with Android P (API 28)
// XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27)}}
#include <stdlib.h> #include <stdlib.h>
#include <type_traits> #include <type_traits>
static_assert(std::is_same<decltype(aligned_alloc(1, 0)), void*>::value, ""); static_assert(std::is_same<decltype(aligned_alloc(1, 0)), void*>::value, "");

libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp

Show All 12 Lines
// ::aligned_alloc is provided by the C library, but it's marked as unavailable // ::aligned_alloc is provided by the C library, but it's marked as unavailable
// until macOS 10.15 // until macOS 10.15
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}} // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
// ::aligned_alloc is not implemented on Windows // ::aligned_alloc is not implemented on Windows
// XFAIL: target={{.+}}-windows-{{.+}} // XFAIL: target={{.+}}-windows-{{.+}}
// ::aligned_alloc is available starting with Android P (API 28)
// XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27)}}
#include <cstdlib> #include <cstdlib>
#include <type_traits> #include <type_traits>
static_assert(std::is_same<decltype(std::aligned_alloc(1, 0)), void*>::value, ""); static_assert(std::is_same<decltype(std::aligned_alloc(1, 0)), void*>::value, "");

libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp

Show All 11 Lines
// UNSUPPORTED: c++03, c++11, c++14 // UNSUPPORTED: c++03, c++11, c++14
// XFAIL: LIBCXX-AIX-FIXME // XFAIL: LIBCXX-AIX-FIXME
// ::timespec_get is provided by the C library, but it's marked as // ::timespec_get is provided by the C library, but it's marked as
// unavailable until macOS 10.15 // unavailable until macOS 10.15
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}} // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
// ::timespec_get is available starting with Android Q (API 29)
// XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27|28)}}
#include <ctime> #include <ctime>
#include <type_traits> #include <type_traits>
#ifndef TIME_UTC #ifndef TIME_UTC
#error TIME_UTC not defined #error TIME_UTC not defined
#endif #endif
std::timespec tmspec = {}; std::timespec tmspec = {};
static_assert(std::is_same<decltype(std::timespec_get(&tmspec, 0)), int>::value, ""); static_assert(std::is_same<decltype(std::timespec_get(&tmspec, 0)), int>::value, "");