This is an archive of the discontinued LLVM Phabricator instance.

Differential D136984

[flang][NFC] Change wording of an I/O runtime error message
ClosedPublic

Authored by klausler on Oct 28 2022, 2:08 PM.

Details

Reviewers
PeteSteinfeld
Commits
rGf8dbe79cc673: [flang] Don't resolve component names to components in derived-type definition…
rGc4c198f603d7: [flang][NFC] Change wording of an I/O runtime error message
Summary

Make a requested change to the wording of a fatal I/O error
message.

Diff Detail

Event Timeline

klausler created this revision.Oct 28 2022, 2:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2022, 2:08 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Oct 28 2022, 2:08 PM
PeteSteinfeld accepted this revision.Oct 28 2022, 2:59 PM

Looks good!

This revision is now accepted and ready to land.Oct 28 2022, 2:59 PM
Harbormaster completed remote builds in B195010: Diff 471650.Oct 28 2022, 3:06 PM
Closed by commit rGc4c198f603d7: [flang][NFC] Change wording of an I/O runtime error message (authored by klausler). · Explain WhyOct 30 2022, 1:37 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rGc4c198f603d7: [flang][NFC] Change wording of an I/O runtime error message.
klausler added a commit: rGf8dbe79cc673: [flang] Don't resolve component names to components in derived-type definition….Oct 30 2022, 1:42 PM

Revision Contents

PathSize
flang/
runtime/
4 lines

Diff 471650

flang/runtime/descriptor-io.h

Context not available.
const SubscriptValue subscripts[]) { const SubscriptValue subscripts[]) {
A *p{descriptor.Element<A>(subscripts)}; A *p{descriptor.Element<A>(subscripts)};
if (!p) { if (!p) {
io.GetIoErrorHandler().Crash( io.GetIoErrorHandler().Crash("Bad address for I/O item -- null base "
"ExtractElement: null base address or subscripts out of range"); "address or subscripts out of range");
} }
return *p; return *p;
} }
Context not available.