This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Document QSetDetachOnError packet
ClosedPublic

Authored by fdeazeve on Oct 28 2022, 8:42 AM.

Details

Summary

The packet was introduced in 106d02866d4d54b09c08e6a12915dba58e709294.

Diff Detail

Event Timeline

fdeazeve created this revision.Oct 28 2022, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2022, 8:42 AM
fdeazeve requested review of this revision.Oct 28 2022, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2022, 8:42 AM
jingham accepted this revision.Oct 28 2022, 9:42 AM

LGTM, thanks for adding this.

This revision is now accepted and ready to land.Oct 28 2022, 9:42 AM
jasonmolenda accepted this revision.Oct 31 2022, 10:09 AM

LGTM. Not really the place for it, but the idea is: if lldb launched a process, when lldb quits, the inferior process should be killed. But if lldb attached to a running process, when lldb quits, the inferior process should be detached from & left running. debugserver often can't tell the difference between these (when you run a process on a local system, lldb actually does the posix_spawn and then tells debugserver to attach to it).

debugserver often can't tell the difference between these (when you run a process on a local system, lldb actually does the posix_spawn and then tells debugserver to attach to it).

That makes a lot of sense!

This revision was automatically updated to reflect the committed changes.