This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
libclc/
-
CMakeLists.txt

Differential D136772

Add auto-generated convert.cl file to clspv and clspv64 target.
ClosedPublic

Authored by aarongreig on Oct 26 2022, 9:23 AM.

Download Raw Diff

Details

Reviewers

rjodinchr
kpet

Summary

Vulkan SPIR-V isn't sufficient to implement all OpenCL rounding modes so we need to be able to link the soft implementations.

This contribution is being made by Codeplay on behalf of Samsung.

Diff Detail

Event Timeline

aarongreig created this revision.Oct 26 2022, 9:23 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2022, 9:23 AM

Herald added subscribers: jvesely, Anastasia. · View Herald Transcript

aarongreig requested review of this revision.Oct 26 2022, 9:23 AM

Harbormaster completed remote builds in B194429: Diff 470834.Oct 26 2022, 9:24 AM

aarongreig edited the summary of this revision. (Show Details)Oct 26 2022, 9:25 AM

aarongreig added reviewers: rjodinchr, kpet.Dec 13 2022, 6:25 AM

rjodinchr accepted this revision.Dec 13 2022, 6:26 AM

This revision is now accepted and ready to land.Dec 13 2022, 6:26 AM

Rebased on tip.

Harbormaster completed remote builds in B203158: Diff 482904.Dec 14 2022, 9:50 AM

rjodinchr accepted this revision.Dec 14 2022, 9:50 AM

kpet mentioned this in rG290308a99e6b: libclc: add generated convert.cl to clspv/clspv64 targets.Feb 14 2023, 10:21 AM

Landed as 290308a99e6b9e6f808a9824c8e5a58a65749585.

Revision Contents

Path

Size

libclc/

6 lines

Diff 470834

libclc/CMakeLists.txt

Context not available.

	# Add the generated convert.cl here to prevent adding			# Add the generated convert.cl here to prevent adding
	# the one listed in SOURCES			# the one listed in SOURCES
	if( NOT ${ARCH} STREQUAL "spirv" AND NOT ${ARCH} STREQUAL "spirv64" AND			if( NOT ${ARCH} STREQUAL "spirv" AND NOT ${ARCH} STREQUAL "spirv64")
	NOT ${ARCH} STREQUAL "clspv" AND NOT ${ARCH} STREQUAL "clspv64" )
	set( rel_files convert.cl )			set( rel_files convert.cl )
	set( objects convert.cl )			set( objects convert.cl )
	if( NOT ENABLE_RUNTIME_SUBNORMAL )			if( NOT ENABLE_RUNTIME_SUBNORMAL AND NOT ${ARCH} STREQUAL "clspv" AND NOT
				${ARCH} STREQUAL "clspv64" )
	list( APPEND rel_files generic/lib/subnormal_use_default.ll )			list( APPEND rel_files generic/lib/subnormal_use_default.ll )
	endif()			endif()
	else()			else()
Context not available.