This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] add some APIs for merger to query the tensor id for output tensor and synthetic tensor.
ClosedPublic

Authored by Peiming on Oct 24 2022, 11:41 AM.

Diff Detail

Event Timeline

Peiming created this revision.Oct 24 2022, 11:41 AM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Oct 24 2022, 11:41 AM
aartbik accepted this revision.Oct 24 2022, 11:44 AM
aartbik added inline comments.
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
234

I think the /// comment technically needs to be "per" method, not for a group, so

/// Gets the id of the output tensor.
unsigned getOutTensorID() const { return outTensor; }

/// Gets the id of the synthetic tensor (used for all invariant tensor expressions).
unsigned getSynTensorID() const { return syntheticTensor; }

This revision is now accepted and ready to land.Oct 24 2022, 11:44 AM
Peiming updated this revision to Diff 470239.Oct 24 2022, 11:46 AM

address comments.

This revision was landed with ongoing or failed builds.Oct 24 2022, 11:49 AM
This revision was automatically updated to reflect the committed changes.