This is an archive of the discontinued LLVM Phabricator instance.

[lit][REQUIRES] Fix llvm-debuginfod.test so it will run
ClosedPublic

Authored by probinson on Oct 24 2022, 9:15 AM.

Details

Summary

The test was added in D114846 but missed one place to introduce the
'httplib' feature keyword, so it has been UNSUPPORTED everywhere.

I don't have curl or httplib locally; I can hack my lit config to
verify this keeps the test from being UNSUPPORTED everywhere, but
someone else will need to verify that it actually works.

Diff Detail

Event Timeline

probinson created this revision.Oct 24 2022, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 9:15 AM
probinson requested review of this revision.Oct 24 2022, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 9:15 AM
mysterymath accepted this revision.Oct 24 2022, 1:45 PM

Ah, thanks for finding this. I've been able to verify that this allows the llvm-debuginfod.test test to run and pass when the build is configured with curl and httplib.

This revision is now accepted and ready to land.Oct 24 2022, 1:45 PM
This revision was automatically updated to reflect the committed changes.