llvm-reduce: Add a reduction to replace atomics with non-atomics

[arsenm]

Summary

Make load and store non-atomic. Make the others monotonic.

We could probably try to incrementally relax the orderings; not sure
how useful that would be.

[aeubanks]

setAtomic also sets syncscope, lgtm

llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp

106

Ordering

[arsenm]

83da1a6a3fe81c382ea03177a4422d0ec8cfcff6

llvm/test/tools/llvm-reduce/reduce-atomic-ordering.ll

+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=atomic-ordering --test FileCheck --test-arg --check-prefixes=INTERESTING,CHECK --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck -check-prefixes=RESULT,CHECK %s < %t
+
+; CHECK-LABEL: @load_atomic_keep(
+; INTERESTING: seq_cst
+; RESULT: %op = load atomic i32, ptr %ptr syncscope("agent") seq_cst, align 4
+define i32 @load_atomic_keep(ptr %ptr) {
+  %op = load atomic i32, ptr %ptr syncscope("agent") seq_cst, align 4
+  ret i32 %op
+}
+
+; CHECK-LABEL: @load_atomic_drop(
+; INTERESTING: load
+; RESULT: %op = load i32, ptr %ptr, align 4
+define i32 @load_atomic_drop(ptr %ptr) {
+  %op = load atomic i32, ptr %ptr syncscope("agent") seq_cst, align 4
+  ret i32 %op
+}
+
+; CHECK-LABEL: @store_atomic_keep(
+; INTERESTING: syncscope("agent")
+; RESULT: store atomic i32 0, ptr %ptr syncscope("agent") seq_cst, align 4
+define void @store_atomic_keep(ptr %ptr) {
+  store atomic i32 0, ptr %ptr syncscope("agent") seq_cst, align 4
+  ret void
+}
+
+; CHECK-LABEL: @store_atomic_drop(
+; INTERESTING: store
+; RESULT: store i32 0, ptr %ptr, align 4
+define void @store_atomic_drop(ptr %ptr) {
+  store atomic i32 0, ptr %ptr syncscope("agent") seq_cst, align 4
+  ret void
+}
+
+; CHECK-LABEL: @atomicrmw_atomic_seq_cst_keep(
+; INTERESTING: seq_cst
+; RESULT: %val = atomicrmw add ptr %ptr, i32 3 syncscope("agent") seq_cst, align 4
+define i32 @atomicrmw_atomic_seq_cst_keep(ptr %ptr) {
+  %val = atomicrmw add ptr %ptr, i32 3 syncscope("agent") seq_cst, align 4
+  ret i32 %val
+}
+
+; CHECK-LABEL: @atomicrmw_atomic_seq_cst_drop(
+; INTERESTING: atomicrmw
+; RESULT: %val = atomicrmw add ptr %ptr, i32 3 monotonic, align 4
+define i32 @atomicrmw_atomic_seq_cst_drop(ptr %ptr) {
+  %val = atomicrmw add ptr %ptr, i32 3 seq_cst
+  ret i32 %val
+}
+
+; CHECK-LABEL: @cmpxchg_atomic_seq_cst_seq_cst_keep(
+; INTERESTING: seq_cst seq_cst
+; RESULT: %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst, align 4
+define { i32, i1 } @cmpxchg_atomic_seq_cst_seq_cst_keep(ptr %ptr, i32 %old, i32 %in) {
+  %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst
+  ret { i32, i1 } %val
+}
+
+; CHECK-LABEL: @cmpxchg_seq_cst_seq_cst_keep_left(
+; INTERESTING: syncscope("agent") seq_cst
+; RESULT: %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst monotonic, align 4
+define { i32, i1 } @cmpxchg_seq_cst_seq_cst_keep_left(ptr %ptr, i32 %old, i32 %in) {
+  %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst
+  ret { i32, i1 } %val
+}
+
+; CHECK-LABEL: @cmpxchg_seq_cst_seq_cst_keep_right(
+; INTERESTING: seq_cst, align 4
+; RESULT: %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") monotonic seq_cst, align 4
+define { i32, i1 } @cmpxchg_seq_cst_seq_cst_keep_right(ptr %ptr, i32 %old, i32 %in) {
+  %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst, align 4
+  ret { i32, i1 } %val
+}
+
+; CHECK-LABEL: @cmpxchg_seq_cst_seq_cst_drop(
+; INTERESTING: = cmpxchg ptr
+; RESULT: %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") monotonic monotonic, align 4
+define { i32, i1 } @cmpxchg_seq_cst_seq_cst_drop(ptr %ptr, i32 %old, i32 %in) {
+  %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst
+  ret { i32, i1 } %val
+}

llvm/tools/llvm-reduce/DeltaManager.cpp

do {                                                                         \
     DELTA_PASS("operands-nan", reduceOperandsNaNDeltaPass)                     \
     DELTA_PASS("operands-to-args", reduceOperandsToArgsDeltaPass)              \
     DELTA_PASS("operands-skip", reduceOperandsSkipDeltaPass)                   \
     DELTA_PASS("operand-bundles", reduceOperandBundesDeltaPass)                \
     DELTA_PASS("attributes", reduceAttributesDeltaPass)                        \
     DELTA_PASS("module-data", reduceModuleDataDeltaPass)                       \
     DELTA_PASS("opcodes", reduceOpcodesDeltaPass)                              \
     DELTA_PASS("volatile", reduceVolatileInstructionsDeltaPass)                \
+    DELTA_PASS("atomic-ordering", reduceAtomicOrderingDeltaPass)               \
     DELTA_PASS("syncscopes", reduceAtomicSyncScopesDeltaPass)                  \
     DELTA_PASS("instruction-flags", reduceInstructionFlagsDeltaPass)           \
 } while (false)
 
 #define DELTA_PASSES_MIR                                                       \
   do {                                                                         \
     DELTA_PASS("instructions", reduceInstructionsMIRDeltaPass)                 \
     DELTA_PASS("ir-instruction-references",                                    \

llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.h

 //===- ReduceMemoryOperations.h - Specialized Delta Pass --------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_TOOLS_LLVM_REDUCE_DELTAS_REDUCEMEMORYOPERATIONS_H
 #define LLVM_TOOLS_LLVM_REDUCE_DELTAS_REDUCEMEMORYOPERATIONS_H
 
 #include "TestRunner.h"
 
 namespace llvm {
 void reduceVolatileInstructionsDeltaPass(TestRunner &Test);
 void reduceAtomicSyncScopesDeltaPass(TestRunner &Test);
+void reduceAtomicOrderingDeltaPass(TestRunner &Test);
 } // namespace llvm
 
 #endif

llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp

static void reduceAtomicSyncScopesInModule(Oracle &O, Module &Mod) {
   for (Function &F : Mod)
     reduceAtomicSyncScopesInFunction(O, F);
 }
 
 void llvm::reduceAtomicSyncScopesDeltaPass(TestRunner &Test) {
   runDeltaPass(Test, reduceAtomicSyncScopesInModule,
                "Reducing Atomic Sync Scopes");
 }
+
+// TODO: Might be helpful to incrementally relax orders
+static void reduceAtomicOrderingInFunction(Oracle &O, Function &F) {
+  for (Instruction &I : instructions(F)) {
+    if (LoadInst *LI = dyn_cast<LoadInst>(&I)) {
+      if (LI->getOrdering() != AtomicOrdering::NotAtomic && !O.shouldKeep())
+        LI->setAtomic(AtomicOrdering::NotAtomic);
+    } else if (StoreInst *SI = dyn_cast<StoreInst>(&I)) {
+      if (SI->getOrdering() != AtomicOrdering::NotAtomic && !O.shouldKeep())
+        SI->setAtomic(AtomicOrdering::NotAtomic);
+    } else if (AtomicRMWInst *RMW = dyn_cast<AtomicRMWInst>(&I)) {
+      if (RMW->getOrdering() != AtomicOrdering::Monotonic && !O.shouldKeep())
+        RMW->setOrdering(AtomicOrdering::Monotonic);
+    } else if (AtomicCmpXchgInst *CmpXChg = dyn_cast<AtomicCmpXchgInst>(&I)) {
+      if (CmpXChg->getSuccessOrdering() != AtomicOrdering::Monotonic &&
+          !O.shouldKeep())
+        CmpXChg->setSuccessOrdering(AtomicOrdering::Monotonic);
+      if (CmpXChg->getFailureOrdering() != AtomicOrdering::Monotonic &&
+          !O.shouldKeep())
+        CmpXChg->setFailureOrdering(AtomicOrdering::Monotonic);
+    }
+  }
+}
+
+static void reduceAtomicOrderingInModule(Oracle &O, Module &Mod) {
+  for (Function &F : Mod)
+    reduceAtomicOrderingInFunction(O, F);
+}
+
+void llvm::reduceAtomicOrderingDeltaPass(TestRunner &Test) {
+  runDeltaPass(Test, reduceAtomicOrderingInModule, "Reducing Atomic Odering");
+}