This is an archive of the discontinued LLVM Phabricator instance.

Differential D136371

[trace][intel pt] Correctly treat kernel CPUs as individual threads
ClosedPublic

Authored by persona0220 on Oct 20 2022, 12:38 PM.

Details

Reviewers
wallace
jj10306
Commits
rG20c7ec127240: [lldb][trace] Correctly treat kernel CPUs as individual threads
Summary

Resolved a bug in kernel decoding and correctly treat kernel CPUs as individual threads.

Diff Detail

Event Timeline

persona0220 created this revision.Oct 20 2022, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 12:38 PM
persona0220 requested review of this revision.Oct 20 2022, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 12:38 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B193301: Diff 469319.Oct 20 2022, 12:41 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptOct 20 2022, 12:41 PM
wallace accepted this revision.Oct 20 2022, 12:50 PM

nice. I expected something as simple as that

This revision is now accepted and ready to land.Oct 20 2022, 12:50 PM
Closed by commit rG20c7ec127240: [lldb][trace] Correctly treat kernel CPUs as individual threads (authored by persona0220). · Explain WhyOct 20 2022, 1:47 PM
This revision was automatically updated to reflect the committed changes.
persona0220 added a commit: rG20c7ec127240: [lldb][trace] Correctly treat kernel CPUs as individual threads.

Revision Contents

PathSize
lldb/
source/
Plugins/
Trace/
intel-pt/
2 lines

Diff 469319

lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 LinesTraceIntelPTSP TraceIntelPT::CreateInstanceForPostmortemTrace(
JSONTraceBundleDescription &bundle_description, JSONTraceBundleDescription &bundle_description,
ArrayRef<ProcessSP> traced_processes, ArrayRef<ProcessSP> traced_processes,
ArrayRef<ThreadPostMortemTraceSP> traced_threads, TraceMode trace_mode) { ArrayRef<ThreadPostMortemTraceSP> traced_threads, TraceMode trace_mode) {
TraceIntelPTSP trace_sp( TraceIntelPTSP trace_sp(
new TraceIntelPT(bundle_description, traced_processes, trace_mode)); new TraceIntelPT(bundle_description, traced_processes, trace_mode));
trace_sp->m_storage.tsc_conversion = trace_sp->m_storage.tsc_conversion =
bundle_description.tsc_perf_zero_conversion; bundle_description.tsc_perf_zero_conversion;
if (bundle_description.cpus) { if (bundle_description.cpus && trace_mode == TraceMode::UserMode) {
std::vector<cpu_id_t> cpus; std::vector<cpu_id_t> cpus;
for (const JSONCpu &cpu : *bundle_description.cpus) { for (const JSONCpu &cpu : *bundle_description.cpus) {
trace_sp->SetPostMortemCpuDataFile(cpu.id, IntelPTDataKinds::kIptTrace, trace_sp->SetPostMortemCpuDataFile(cpu.id, IntelPTDataKinds::kIptTrace,
FileSpec(cpu.ipt_trace)); FileSpec(cpu.ipt_trace));
trace_sp->SetPostMortemCpuDataFile( trace_sp->SetPostMortemCpuDataFile(
cpu.id, IntelPTDataKinds::kPerfContextSwitchTrace, cpu.id, IntelPTDataKinds::kPerfContextSwitchTrace,
▲ Show 20 Lines • Show All 567 Lines • Show Last 20 Lines