This is an archive of the discontinued LLVM Phabricator instance.

Differential D136369

[MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC)
ClosedPublic

Authored by kda on Oct 20 2022, 10:32 AM.

Details

Reviewers
vitalybuka
Commits
rG67ad31c88e8b: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC)

Diff Detail

Unit TestsFailed

TimeTest
60,060 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

kda created this revision.Oct 20 2022, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 10:32 AM
kda requested review of this revision.Oct 20 2022, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 10:32 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B193275: Diff 469283.Oct 20 2022, 11:24 AM
kda updated this revision to Diff 469331.Oct 20 2022, 1:13 PM

added x86 non-vector versions

vitalybuka added inline comments.Oct 20 2022, 1:55 PM
llvm/test/Instrumentation/MemorySanitizer/count-zeroes.ll
42

can you please also add cases with false here?

Harbormaster completed remote builds in B193308: Diff 469331.Oct 20 2022, 2:00 PM
vitalybuka added inline comments.Oct 20 2022, 5:33 PM
llvm/test/Instrumentation/MemorySanitizer/count-zeroes.ll
6

Maybe you can drop this line?

kda updated this revision to Diff 469872.Oct 22 2022, 2:22 AM

add no zero poison versions

kda marked an inline comment as done.Oct 22 2022, 2:23 AM
kda added inline comments.
llvm/test/Instrumentation/MemorySanitizer/count-zeroes.ll
6

keeping this as discussed.

kda added a child revision: D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..Oct 22 2022, 2:26 AM
Harbormaster completed remote builds in B193720: Diff 469872.Oct 22 2022, 3:03 AM
kda retitled this revision from [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. to [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).Oct 24 2022, 4:12 PM
vitalybuka accepted this revision.Oct 24 2022, 5:14 PM
This revision is now accepted and ready to land.Oct 24 2022, 5:14 PM
Closed by commit rG67ad31c88e8b: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC) (authored by kda). · Explain WhyOct 24 2022, 5:19 PM
This revision was automatically updated to reflect the committed changes.
kda added a commit: rG67ad31c88e8b: [MSAN] Count Zeroes test for covering ctlz and cttz under MSAN. (NFC).

Revision Contents

PathSize
llvm/
test/
Instrumentation/
MemorySanitizer/
48 lines

Diff 469283

llvm/test/Instrumentation/MemorySanitizer/count-zeroes.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt %s -S -passes=msan 2>&1 | FileCheck %s
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

Maybe you can drop this line?

vitalybuka: Maybe you can drop this line?
kdaAuthorUnsubmitted
Done
ReplyInline Actions

keeping this as discussed.

kda: keeping this as discussed.
define <2 x i64> @test_ctlz_v2i64(<2 x i64> %v) #0 {
; CHECK-LABEL: @test_ctlz_v2i64(
; CHECK-NEXT: [[TMP1:%.*]] = load <2 x i64>, ptr @__msan_param_tls, align 8
; CHECK-NEXT: call void @llvm.donothing()
; CHECK-NEXT: [[TMP2:%.*]] = bitcast <2 x i64> [[TMP1]] to i128
; CHECK-NEXT: [[_MSCMP:%.*]] = icmp ne i128 [[TMP2]], 0
; CHECK-NEXT: br i1 [[_MSCMP]], label [[TMP3:%.*]], label [[TMP4:%.*]], !prof [[PROF0:![0-9]+]]
; CHECK: 3:
; CHECK-NEXT: call void @__msan_warning_noreturn() #[[ATTR4:[0-9]+]]
; CHECK-NEXT: unreachable
; CHECK: 4:
; CHECK-NEXT: [[RES:%.*]] = call <2 x i64> @llvm.ctlz.v2i64(<2 x i64> [[V:%.*]], i1 true)
; CHECK-NEXT: store <2 x i64> zeroinitializer, ptr @__msan_retval_tls, align 8
; CHECK-NEXT: ret <2 x i64> [[RES]]
;
%res = call <2 x i64> @llvm.ctlz.v2i64(<2 x i64> %v, i1 true) ; <<2 x i64>> [#uses=1]
ret <2 x i64> %res
}
declare <2 x i64> @llvm.ctlz.v2i64(<2 x i64>, i1) nounwind readnone
define <2 x i64> @test_cttz_v2i64(<2 x i64> %v) #0 {
; CHECK-LABEL: @test_cttz_v2i64(
; CHECK-NEXT: [[TMP1:%.*]] = load <2 x i64>, ptr @__msan_param_tls, align 8
; CHECK-NEXT: call void @llvm.donothing()
; CHECK-NEXT: [[TMP2:%.*]] = bitcast <2 x i64> [[TMP1]] to i128
; CHECK-NEXT: [[_MSCMP:%.*]] = icmp ne i128 [[TMP2]], 0
; CHECK-NEXT: br i1 [[_MSCMP]], label [[TMP3:%.*]], label [[TMP4:%.*]], !prof [[PROF0]]
; CHECK: 3:
; CHECK-NEXT: call void @__msan_warning_noreturn() #[[ATTR4]]
; CHECK-NEXT: unreachable
; CHECK: 4:
; CHECK-NEXT: [[RES:%.*]] = call <2 x i64> @llvm.cttz.v2i64(<2 x i64> [[V:%.*]], i1 true)
; CHECK-NEXT: store <2 x i64> zeroinitializer, ptr @__msan_retval_tls, align 8
; CHECK-NEXT: ret <2 x i64> [[RES]]
;
%res = call <2 x i64> @llvm.cttz.v2i64(<2 x i64> %v, i1 true) ; <<2 x i64>> [#uses=1]
vitalybukaUnsubmitted
Done
ReplyInline Actions

can you please also add cases with false here?

vitalybuka: can you please also add cases with false here?
ret <2 x i64> %res
}
declare <2 x i64> @llvm.cttz.v2i64(<2 x i64>, i1) nounwind readnone
attributes #0 = { sanitize_memory }