[libc++] implement move_iterator<T*> should be a random access iterator

[Mordante]

Thanks for your contribution!Please rebase the patch and make sure it can be applied, then the CI can test your patch.

libcxx/include/__iterator/move_iterator.h

63

This is a style change we recently did.

[ldionne]

[Github PR transition cleanup] This was done in https://reviews.llvm.org/D135248, closing.

libcxx/include/__iterator/move_iterator.h

 
 template <class _Iter>
 class _LIBCPP_TEMPLATE_VIS move_iterator
 #if _LIBCPP_STD_VER > 17
     : public __move_iter_category_base<_Iter>
 #endif
 {
     private:
-   
-   static constexpr auto _Get_Iterator_Tag() {
-     if constexpr (__is_cpp17_random_access_iterator<_Iter>::value) {
+    #if _LIBCPP_STD_VER > 17
+   static consteval auto _get_iterator_concept() {
+     if constexpr (random_access_iterator<_Iter>) {
         return random_access_iterator_tag{};
-     } else if constexpr (__is_cpp17_forward_iterator<_Iter>::value) {
-        return forward_iterator_tag{};
-     } else if constexpr (__is_cpp17_bidirectional_iterator<_Iter>::value) {
+     }  else if constexpr (bidirectional_iterator<_Iter>) {
         return bidirectional_iterator_tag{};
+     } else if constexpr (forward_iterator<_Iter>) {
+        return forward_iterator_tag{};
      } else {
         return input_iterator_tag{}; 
      }
    }
+   #endif //_LIBCPP_STD_VER > 17  
     template<class _It2> friend class move_iterator;
 
     _Iter __current_;
     
 public:
 #if _LIBCPP_STD_VER > 17
     using iterator_type = _Iter;
-    using iterator_concept = decltype(_Get_Iterator_Tag());
+    using iterator_concept = decltype(_get_iterator_concept());
     // iterator_category is inherited and not always present
     using value_type = iter_value_t<_Iter>;
     using difference_type = iter_difference_t<_Iter>;
     using pointer = _Iter;
     using reference = iter_rvalue_reference_t<_Iter>;
 #else
     typedef _Iter iterator_type;
     typedef _If<

libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/types.pass.cpp

#if TEST_STD_VER >= 11
       typedef DummyIt<int, int&&> T;
       typedef std::move_iterator<T> It;
       static_assert(std::is_same<It::reference, int&&>::value, "");
   }
 #endif
 
 #if TEST_STD_VER > 17
   test<contiguous_iterator<char*>>();
-  static_assert(std::is_same_v<typename std::move_iterator<forward_iterator<char*>>::iterator_concept, std::input_iterator_tag>);
-  static_assert(std::is_same_v<typename std::move_iterator<bidirectional_iterator<char*>>::iterator_concept, std::input_iterator_tag>);
-  static_assert(std::is_same_v<typename std::move_iterator<random_access_iterator<char*>>::iterator_concept, std::input_iterator_tag>);
-  static_assert(std::is_same_v<typename std::move_iterator<contiguous_iterator<char*>>::iterator_concept, std::input_iterator_tag>);
-  static_assert(std::is_same_v<typename std::move_iterator<char*>::iterator_concept, std::input_iterator_tag>);
+  static_assert(std::is_same_v<typename std::move_iterator<forward_iterator<char*>>::iterator_concept, std::forward_iterator_tag>);
+  static_assert(std::is_same_v<typename std::move_iterator<bidirectional_iterator<char*>>::iterator_concept, std::bidirectional_iterator_tag>);
+  static_assert(std::is_same_v<typename std::move_iterator<random_access_iterator<char*>>::iterator_concept, std::random_access_iterator_tag>);
+  static_assert(std::is_same_v<typename std::move_iterator<contiguous_iterator<char*>>::iterator_concept, std::random_access_iterator_tag>);
+  static_assert(std::is_same_v<typename std::move_iterator<char*>::iterator_concept, std::random_access_iterator_tag>);
 #endif
 
   return 0;
 }