This is an archive of the discontinued LLVM Phabricator instance.

Forward CMake options to runtimes builds
AbandonedPublic

Authored by kongyi on Oct 19 2022, 10:44 AM.

Details

Reviewers
phosek
Summary

We specify custom -B in our CMake options, they have to be forwarded to the runtimes builds. Also, OSX target and arch flags need to be passed through to build as universal binary.

Diff Detail

Event Timeline

kongyi created this revision.Oct 19 2022, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 10:44 AM
kongyi requested review of this revision.Oct 19 2022, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 10:44 AM

This is not the right approach and it'll break common uses of the bootstrapping build since the host flags don't necessarily apply to target, especially when cross-compiling.

kongyi abandoned this revision.Dec 12 2022, 9:39 PM