This is an archive of the discontinued LLVM Phabricator instance.

clang/lib/Sema/SemaTemplateDeduction.cpp
5807–5810	NIT: maybe keep a single if statement and use `dyn_cast_or_null`?
clang/test/SemaTemplate/concepts-GH53354.cpp
19 ↗	(On Diff #468925)	why not `&& true`!?

Addressed comments.

LGTM, thanks!

This revision is now accepted and ready to land.Oct 20 2022, 1:20 AM

This revision was landed with ongoing or failed builds.Oct 20 2022, 1:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

clang/

lib/

Sema/

8 lines

Show First 20 Lines • Show All 5,798 Lines • ▼ Show 20 Lines	struct MarkUsedTemplateParameterVisitor :

bool VisitTemplateTypeParmType(TemplateTypeParmType *T) {		bool VisitTemplateTypeParmType(TemplateTypeParmType *T) {
if (T->getDepth() == Depth)		if (T->getDepth() == Depth)
Used[T->getIndex()] = true;		Used[T->getIndex()] = true;
return true;		return true;
}		}

bool TraverseTemplateName(TemplateName Template) {		bool TraverseTemplateName(TemplateName Template) {
if (auto *TTP =		if (TemplateDecl *TD = Template.getAsTemplateDecl())
dyn_cast<TemplateTemplateParmDecl>(Template.getAsTemplateDecl()))		if (auto *TTP = dyn_cast<TemplateTemplateParmDecl>(TD))
if (TTP->getDepth() == Depth)		if (TTP->getDepth() == Depth)
Used[TTP->getIndex()] = true;		Used[TTP->getIndex()] = true;
		ilya-biryukovUnsubmitted Done Reply Inline Actions NIT: maybe keep a single if statement and use `dyn_cast_or_null`? ilya-biryukov: NIT: maybe keep a single if statement and use `dyn_cast_or_null`?
RecursiveASTVisitor<MarkUsedTemplateParameterVisitor>::		RecursiveASTVisitor<MarkUsedTemplateParameterVisitor>::
TraverseTemplateName(Template);		TraverseTemplateName(Template);
return true;		return true;
}		}

bool VisitDeclRefExpr(DeclRefExpr *E) {		bool VisitDeclRefExpr(DeclRefExpr *E) {
if (auto *NTTP = dyn_cast<NonTypeTemplateParmDecl>(E->getDecl()))		if (auto *NTTP = dyn_cast<NonTypeTemplateParmDecl>(E->getDecl()))
if (NTTP->getDepth() == Depth)		if (NTTP->getDepth() == Depth)
▲ Show 20 Lines • Show All 490 Lines • Show Last 20 Lines