This is an archive of the discontinued LLVM Phabricator instance.

Differential D136229

[include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON
ClosedPublic

Authored by lkail on Oct 18 2022, 10:50 PM.

Details

Reviewers
hokein
sammccall
Group Reviewers
Restricted Project
Commits
rG2e73129483c4: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON
Summary

Fixed ppc buildbot https://lab.llvm.org/buildbot/#/builders/121/builds/24273 which is using -DBUILD_SHARED_LIBS=ON.

Diff Detail

Event Timeline

lkail created this revision.Oct 18 2022, 10:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 10:50 PM
lkail requested review of this revision.Oct 18 2022, 10:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 10:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B192912: Diff 468786.Oct 18 2022, 11:09 PM
sammccall accepted this revision.Oct 19 2022, 12:18 AM

Thank you!

This revision is now accepted and ready to land.Oct 19 2022, 12:18 AM
Closed by commit rG2e73129483c4: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON (authored by lkail). · Explain WhyOct 19 2022, 12:26 AM
This revision was automatically updated to reflect the committed changes.
lkail added a commit: rG2e73129483c4: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON.

Revision Contents

PathSize
clang-tools-extra/
include-cleaner/
lib/
3 lines
tool/
2 lines

Diff 468796

clang-tools-extra/include-cleaner/lib/CMakeLists.txt

set(LLVM_LINK_COMPONENTS Support) set(LLVM_LINK_COMPONENTS Support)
add_clang_library(clangIncludeCleaner add_clang_library(clangIncludeCleaner
HTMLReport.cpp HTMLReport.cpp
Record.cpp Record.cpp
WalkAST.cpp WalkAST.cpp
LINK_LIBS LINK_LIBS
clangBasic
clangAST clangAST
clangBasic
clangLex
) )

clang-tools-extra/include-cleaner/tool/CMakeLists.txt

set(LLVM_LINK_COMPONENTS Support) set(LLVM_LINK_COMPONENTS Support)
include_directories("../lib") # FIXME: use public APIs instead. include_directories("../lib") # FIXME: use public APIs instead.
add_clang_tool(clang-include-cleaner IncludeCleaner.cpp) add_clang_tool(clang-include-cleaner IncludeCleaner.cpp)
clang_target_link_libraries(clang-include-cleaner PRIVATE clang_target_link_libraries(clang-include-cleaner PRIVATE
clangBasic clangBasic
clangFrontend
clangSerialization
clangTooling clangTooling
) )
target_link_libraries(clang-include-cleaner PRIVATE target_link_libraries(clang-include-cleaner PRIVATE
clangIncludeCleaner clangIncludeCleaner
) )