This is an archive of the discontinued LLVM Phabricator instance.

Differential D135629

[libc] fix header list for x86_64
ClosedPublic

Authored by michaelrj on Oct 10 2022, 3:51 PM.

Details

Reviewers
sivachandra
lntue
Commits
rGa6abcfee8a28: [libc] fix header list for x86_64
Summary

Some headers hadn't been added, this fixes that and improves the
ordering.

Diff Detail

Event Timeline

michaelrj created this revision.Oct 10 2022, 3:51 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 10 2022, 3:51 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Oct 10 2022, 3:51 PM
sivachandra accepted this revision.Oct 10 2022, 3:54 PM
sivachandra added inline comments.
libc/config/linux/x86_64/headers.txt
19

Why the empty line?

This revision is now accepted and ready to land.Oct 10 2022, 3:54 PM
Harbormaster completed remote builds in B191393: Diff 466656.Oct 10 2022, 3:56 PM
michaelrj marked an inline comment as done.Oct 10 2022, 4:04 PM
michaelrj added inline comments.
libc/config/linux/x86_64/headers.txt
19

to make the separation between the items inside sys and those not more clear.

Closed by commit rGa6abcfee8a28: [libc] fix header list for x86_64 (authored by michaelrj). · Explain WhyOct 10 2022, 4:06 PM
This revision was automatically updated to reflect the committed changes.
michaelrj marked an inline comment as done.
michaelrj added a commit: rGa6abcfee8a28: [libc] fix header list for x86_64.

Revision Contents

PathSize
libc/
config/
linux/
x86_64/
13 lines

Diff 466659

libc/config/linux/x86_64/headers.txt

set(TARGET_PUBLIC_HEADERS set(TARGET_PUBLIC_HEADERS
libc.include.assert_h libc.include.assert_h
libc.include.ctype libc.include.ctype
libc.include.dirent
libc.include.errno libc.include.errno
libc.include.fcntl
libc.include.fenv libc.include.fenv
libc.include.inttypes libc.include.inttypes
libc.include.math libc.include.math
libc.include.pthread libc.include.pthread
libc.include.sched libc.include.sched
libc.include.signal libc.include.signal
libc.include.stdio libc.include.stdio
libc.include.stdlib libc.include.stdlib
libc.include.string libc.include.string
libc.include.threads
libc.include.time
libc.include.unistd
sivachandraUnsubmitted
Done
ReplyInline Actions

Why the empty line?

sivachandra: Why the empty line?
michaelrjAuthorUnsubmitted
Done
ReplyInline Actions

to make the separation between the items inside sys and those not more clear.

michaelrj: to make the separation between the items inside `sys` and those not more clear.
libc.include.sys_ioctl libc.include.sys_ioctl
libc.include.sys_mman libc.include.sys_mman
libc.include.sys_random libc.include.sys_random
libc.include.sys_resource
libc.include.sys_stat
libc.include.sys_syscall libc.include.sys_syscall
libc.include.threads libc.include.sys_utsname
libc.include.time libc.include.sys_wait
libc.include.unistd
) )