Page MenuHomePhabricator

[llvm-reduce] Fix di-metadata pass test failures
ClosedPublic

Authored by ormris on Oct 7 2022, 11:26 AM.

Details

Summary

We're seeing intermittent failures in upstream bots. See:

https://lab.llvm.org/buildbot/#/builders/139/builds/29185
https://lab.llvm.org/buildbot/#/builders/238/builds/295

This appears to be due to the unstable iteration order of DenseSet. Since we're trying to reduce a tree, it makes sense to attempt reductions from the top down.

This also addresses post-review comments from @MatzeB.

Diff Detail

Event Timeline

ormris created this revision.Oct 7 2022, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 11:26 AM
ormris requested review of this revision.Oct 7 2022, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 11:26 AM
aeubanks accepted this revision.Oct 7 2022, 11:54 AM
This revision is now accepted and ready to land.Oct 7 2022, 11:54 AM

Thanks for the review @aeubanks!

This revision was landed with ongoing or failed builds.Oct 7 2022, 12:05 PM
This revision was automatically updated to reflect the committed changes.