This is an archive of the discontinued LLVM Phabricator instance.

Differential D135408

[libc] fix futex type
ClosedPublic

Authored by michaelrj on Oct 6 2022, 3:06 PM.

Details

Reviewers
sivachandra
lntue
Commits
rGf2a99746666e: [libc] fix futex type
Summary

Previously the futex type was defined in terms of unsigned int, now it's
uint32, which is more portable.

Diff Detail

Event Timeline

michaelrj created this revision.Oct 6 2022, 3:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 6 2022, 3:06 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Oct 6 2022, 3:06 PM
sivachandra accepted this revision.Oct 6 2022, 3:11 PM
This revision is now accepted and ready to land.Oct 6 2022, 3:11 PM
Harbormaster completed remote builds in B190829: Diff 465893.Oct 6 2022, 3:11 PM
Closed by commit rGf2a99746666e: [libc] fix futex type (authored by michaelrj). · Explain WhyOct 6 2022, 3:19 PM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGf2a99746666e: [libc] fix futex type.

Revision Contents

PathSize
libc/
include/
llvm-libc-types/
11 lines

Diff 465900

libc/include/llvm-libc-types/__futex_word.h

//===-- Definition of type which can represent a futex word ---------------===// //===-- Definition of type which can represent a futex word ---------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef __LLVM_LIBC_TYPES_FUTEX_WORD_H__ #ifndef __LLVM_LIBC_TYPES_FUTEX_WORD_H__
#define __LLVM_LIBC_TYPES_FUTEX_WORD_H__ #define __LLVM_LIBC_TYPES_FUTEX_WORD_H__
typedef struct { typedef struct {
#if defined(__unix__) && (defined(__x86_64__) || defined(__aarch64__))
// Futex word should be aligned appropriately to allow target atomic // Futex word should be aligned appropriately to allow target atomic
// instructions. This declaration mimics the internal setup. // instructions. This declaration mimics the internal setup.
_Alignas(sizeof(unsigned int) > _Alignof(unsigned int) _Alignas(sizeof(__UINT32_TYPE__) > _Alignof(__UINT32_TYPE__)
? sizeof(unsigned int) ? sizeof(__UINT32_TYPE__)
: _Alignof(unsigned int)) unsigned int __word; : _Alignof(__UINT32_TYPE__)) __UINT32_TYPE__ __word;
_Static_assert(sizeof(unsigned int) == 4, "Unexpected size of unsigned int.");
#else
#error "A type to represent a futex word is not available for the target arch."
#endif
} __futex_word; } __futex_word;
#endif // __LLVM_LIBC_TYPES_FUTEX_WORD_H__ #endif // __LLVM_LIBC_TYPES_FUTEX_WORD_H__