[libc] add kill

[michaelrj]

Summary

Add the kill syscall wrapper and tests.

[sivachandra]

One nit inline and, should you add pid_t somewhere in linux/api.td?

libc/src/signal/linux/kill.cpp

2

kill

[michaelrj]

fix nits and formatting before land

libc/config/linux/api.td

 def SysMManAPI : PublicAPI<"sys/mman.h"> {
   let Types = ["off_t", "size_t"];
   let Macros = [
   ];
 
 }
 
 def SignalAPI : PublicAPI<"signal.h"> {
-  let Types = ["sigset_t", "struct sigaction", "union sigval", "siginfo_t"];
+  let Types = [
+    "sigset_t",
+    "struct sigaction",
+    "union sigval",
+    "siginfo_t",
+    "pid_t",
+  ];
 }
 
 def ThreadsAPI : PublicAPI<"threads.h"> {
   let Macros = [
     SimpleMacroDef<"ONCE_FLAG_INIT", "{0}">,
   ];
 
   let Types = [

libc/config/linux/x86_64/entrypoints.txt

set(TARGET_LIBC_ENTRYPOINTS
     libc.src.fcntl.creat
     libc.src.fcntl.open
     libc.src.fcntl.openat
 
     # sched.h entrypoints
     libc.src.sched.sched_getaffinity
     libc.src.sched.sched_setaffinity
 
+    # signal.h entrypoints
+    libc.src.signal.kill
+
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bzero
     libc.src.string.memccpy
     libc.src.string.memchr
     libc.src.string.memcmp
     libc.src.string.memcpy
     libc.src.string.memmove

libc/include/CMakeLists.txt

add_gen_header(
   GEN_HDR signal.h
   DATA_FILES
     ../config/${LIBC_TARGET_OS}/signal.h.in
   DEPENDS
     .llvm-libc-macros.signal_macros
     .llvm-libc-types.struct_sigaction
     .llvm-libc-types.__sighandler_t
     .llvm-libc-types.sigset_t
+    .llvm-libc-types.pid_t
 )
 
 add_gen_header(
   stdio
   DEF_FILE stdio.h.def
   GEN_HDR stdio.h
   DEPENDS
     .llvm_libc_common_h

libc/spec/posix.td

def POSIX : StandardSpec<"POSIX"> {
   HeaderSpec Signal = HeaderSpec<
       "signal.h",
       [], // Macros
       [
         SigInfoType,
         SigSetType,
         StructSigaction,
         UnionSigVal,
+        PidT,
       ],
       [], // Enumerations
       [
         FunctionSpec<
+          "kill",
+          RetValSpec<IntType>,
+          [ArgSpec<PidT>,
+            ArgSpec<IntType>]
+        >,
+        FunctionSpec<
           "sigaction",
           RetValSpec<IntType>,
           [ArgSpec<IntType>,
            ArgSpec<ConstRestrictedStructSigactionPtr>,
            ArgSpec<RestrictedStructSigactionPtr>]
         >,
         FunctionSpec<
           "sigdelset",

libc/src/signal/CMakeLists.txt

 if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${LIBC_TARGET_OS})
   add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${LIBC_TARGET_OS})
 endif()
 
 add_entrypoint_object(
   raise
   ALIAS
   DEPENDS
     .${LIBC_TARGET_OS}.raise
 )
 
 add_entrypoint_object(
+  kill
+  ALIAS
+  DEPENDS
+    .${LIBC_TARGET_OS}.kill
+)
+
+add_entrypoint_object(
   sigaction
   ALIAS
   DEPENDS
     .${LIBC_TARGET_OS}.sigaction
 )
 
 add_entrypoint_object(
   sigprocmask

libc/src/signal/kill.h

+//===-- Implementation header for kill function -----------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_SIGNAL_KILL_H
+#define LLVM_LIBC_SRC_SIGNAL_KILL_H
+
+#include <signal.h>
+
+namespace __llvm_libc {
+
+int kill(pid_t pid, int sig);
+
+} // namespace __llvm_libc
+
+#endif // LLVM_LIBC_SRC_SIGNAL_KILL_H

libc/src/signal/linux/CMakeLists.txt

 add_header_library(
   signal_utils
   HDRS
     signal_utils.h
   DEPENDS
     libc.include.sys_syscall
     libc.src.__support.OSUtil.osutil
 )
 
 add_entrypoint_object(
+  kill
+  SRCS
+    kill.cpp
+  HDRS
+    ../kill.h
+  DEPENDS
+    libc.include.signal
+    libc.include.errno
+    libc.src.errno.errno
+    libc.include.sys_syscall
+    libc.src.__support.OSUtil.osutil
+)
+
+add_entrypoint_object(
   raise
   SRCS
     raise.cpp
   HDRS
     ../raise.h
   DEPENDS
     .signal_utils
     libc.include.signal

libc/src/signal/linux/kill.cpp

+//===-- Linux implementation of kill --------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/signal/kill.h"
+
+#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "src/signal/linux/signal_utils.h"
+
+#include "src/__support/common.h"
+
+#include <errno.h>
+#include <signal.h>
+#include <sys/syscall.h> // For syscall numbers.
+
+namespace __llvm_libc {
+
+LLVM_LIBC_FUNCTION(int, kill, (pid_t pid, int sig)) {
+  int ret = __llvm_libc::syscall_impl(SYS_kill, pid, sig);
+
+  // A negative return value indicates an error with the magnitude of the
+  // value being the error code.
+  if (ret != 0) {
+    errno = (ret > 0 ? ret : -ret);
+    return -1;
+  }
+
+  return ret; // always 0
+}
+
+} // namespace __llvm_libc

libc/test/src/signal/CMakeLists.txt

 add_libc_testsuite(libc_signal_unittests)
 
 add_libc_unittest(
   raise_test
   SUITE
     libc_signal_unittests
   SRCS
     raise_test.cpp
   DEPENDS
     libc.include.signal
     libc.src.signal.raise
 )
 
 add_libc_unittest(
+  kill_test
+  SUITE
+    libc_signal_unittests
+  SRCS
+    kill_test.cpp
+  DEPENDS
+    libc.include.signal
+    libc.include.errno
+    libc.src.errno.errno
+    libc.src.signal.kill
+    libc.include.sys_syscall
+    libc.src.__support.OSUtil.osutil
+    libc.test.errno_setter_matcher
+)
+
+add_libc_unittest(
   sigaction_test
   SUITE
     libc_signal_unittests
   SRCS
     sigaction_test.cpp
   DEPENDS
     libc.include.errno
     libc.include.signal

libc/test/src/signal/kill_test.cpp

+//===-- Unittests for kill -----------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/signal/kill.h"
+
+#include "include/sys/syscall.h"          // For syscall numbers.
+#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "test/ErrnoSetterMatcher.h"
+#include "utils/UnitTest/Test.h"
+
+#include <errno.h>
+#include <signal.h>
+
+using __llvm_libc::testing::ErrnoSetterMatcher::Succeeds;
+
+TEST(LlvmLibcKillTest, TargetSelf) {
+  pid_t parent_pid = __llvm_libc::syscall_impl(SYS_getpid);
+  ASSERT_THAT(__llvm_libc::kill(parent_pid, 0), Succeeds(0));
+
+  EXPECT_DEATH(
+      [] {
+        pid_t child_pid = __llvm_libc::syscall_impl(SYS_getpid);
+        __llvm_libc::kill(child_pid, SIGKILL);
+      },
+      WITH_SIGNAL(SIGKILL));
+}