Just like we guard other tests with REQUIRES: locale.en_US.UTF-8, it makes sense to
guard this test for its usage of the en_US locale.
Details
Details
- Reviewers
mstorsjo Mordante - Group Reviewers
Restricted Project - Commits
- rG3d118f290149: [libc++] Remove unique usage of the en_US locale in a test
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I came across this in a different context, but please let me know if that doesn't make sense, I'm obviously not a locale expert.
Comment Actions
LGTM, but I would consider an alternate approach and not add this locale to features.py.
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_char.pass.cpp | ||
---|---|---|
16 | Looking at the test it doesn't really matter which locale is used. So I would suggest to use an existing locale in this patch instead, and update the commit title and message. |
Looking at the test it doesn't really matter which locale is used. So I would suggest to use an existing locale in this patch instead, and update the commit title and message.