Page MenuHomePhabricator

Unwind-tables: move back to original logic outline for kind.
ClosedPublic

Authored by t.p.northover on Sep 26 2022, 6:23 AM.

Details

Reviewers
abrachet
Summary

There are lots of options interacting in complex ways here, and when moving to getDefaultUnwindTableLevel I had refactored this and changed behaviour in some cases (see tests added). So this reverts the basic structure of the logic back to the original (prior to 4388b56d52), while leaving the hook in the new style so targets remain simpler.

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::lljit-initialize-deinitialize.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/lli -jit-kind=orc -jit-linker=jitlink -orc-runtime=/var/lib/buildkite-agent/builds/llvm-project/build/./lib/clang/16.0.0/lib/x86_64-unknown-linux-gnu/liborc_rt.a /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/lljit-initialize-deinitialize.ll | FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/lljit-initialize-deinitialize.ll
110 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::priority-static-initializer.S
Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/priority-static-initializer.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/priority-static-initializer.S
100 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-cxa-atexit.S

Event Timeline

t.p.northover created this revision.Sep 26 2022, 6:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 6:23 AM
Herald added a subscriber: mcrosier. · View Herald Transcript
t.p.northover requested review of this revision.Sep 26 2022, 6:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 6:23 AM
Herald added a subscriber: MaskRay. · View Herald Transcript
abrachet accepted this revision.Sep 26 2022, 6:49 AM

Thanks! :)

This revision is now accepted and ready to land.Sep 26 2022, 6:49 AM
t.p.northover closed this revision.Sep 29 2022, 5:39 AM

Sorry about that, committed as e62b3a9375d8.