This is an archive of the discontinued LLVM Phabricator instance.

Differential D134417

[GCC torture tests] Disable 2 tests with array alignment issues
ClosedPublic

Authored by DavidSpickett on Sep 22 2022, 1:11 AM.

Download Raw Diff

Details

Reviewers

ahatanak
efriedma
DavidSpickett

Commits

rTd66d5069cba9: Revert "Use -fprofile-use= when TEST_SUITE_USE_IR_PGO is enabled"
rT48adf16285bb: [GCC torture tests] Disable 2 tests with array alignment issues

Summary

Since https://reviews.llvm.org/D133711 clang has been rejecting
code in these two tests.

Recent GCC also rejects this code.

Diff Detail

Repository

Build Status

Buildable 188120
Build 284319: arc lint + arc unit

Event Timeline

DavidSpickett created this revision.Sep 22 2022, 1:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 1:11 AM

DavidSpickett requested review of this revision.Sep 22 2022, 1:11 AM

Harbormaster completed remote builds in B188120: Diff 462104.Sep 22 2022, 1:11 AM

https://godbolt.org/z/fsGraKeM7 for the GCC behaviour.

Our bots are red all over so landing this without review. I'm pretty sure it's ok. Tell me if it isn't.

https://github.com/llvm/llvm-test-suite/commit/48adf16285bb390029d10f626071ef083aa2c945

This revision is now accepted and ready to land.Sep 22 2022, 4:38 AM

DavidSpickett closed this revision.Sep 22 2022, 4:38 AM

DavidSpickett added a commit: rT48adf16285bb: [GCC torture tests] Disable 2 tests with array alignment issues.Sep 22 2022, 4:39 AM

Seems fine.

I didn't realize the test was failing because of the array alignment patch. Thank you for fixing it.

fhahn added a commit: rTd66d5069cba9: Revert "Use -fprofile-use= when TEST_SUITE_USE_IR_PGO is enabled".Sep 30 2022, 12:35 AM

Revision Contents

Path

Size

SingleSource/

Regression/

C/

gcc-c-torture/

execute/

4 lines

Diff 462104

SingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines		file(GLOB UnsupportedTests CONFIGURE_DEPENDS
	fprintf-chk-1.c			fprintf-chk-1.c
	printf-chk-1.c			printf-chk-1.c
	vfprintf-chk-1.c			vfprintf-chk-1.c
	vprintf-chk-1.c			vprintf-chk-1.c

	# Clang at -O0 does not enable -finstrument-functions			# Clang at -O0 does not enable -finstrument-functions
	# (https://bugs.llvm.org/show_bug.cgi?id=49143)			# (https://bugs.llvm.org/show_bug.cgi?id=49143)
	eeprof-1.c			eeprof-1.c

				# Size of array element is not a multiple of its alignment.
				pr36093.c
				pr43783.c
	)			)
	list(APPEND TestsToSkip ${UnsupportedTests})			list(APPEND TestsToSkip ${UnsupportedTests})

	# Tests where clang currently has bugs or issues			# Tests where clang currently has bugs or issues
	file(GLOB FailingTests CONFIGURE_DEPENDS			file(GLOB FailingTests CONFIGURE_DEPENDS

	# Handling of bitfields is different between clang and GCC:			# Handling of bitfields is different between clang and GCC:
	# http://lists.llvm.org/pipermail/llvm-dev/2017-October/118507.html			# http://lists.llvm.org/pipermail/llvm-dev/2017-October/118507.html
	▲ Show 20 Lines • Show All 231 Lines • Show Last 20 Lines