Page MenuHomePhabricator

Fix bufferization of collapse_shape of subviews with size 1 dims.
ClosedPublic

Authored by jreiffers on Sep 16 2022, 2:10 AM.

Details

Summary

Currently, there's an optimization that claims dimensions of size 1 are always
contiguous. This is not necessarily the case for subviews.

Input:

[
  [
    [0, 1],
    [2, 3]
  ],
  [
    [4, 5]
    [6, 7]
  ]
]

Subview:

  [
    [
      [0, 1],
    ],
    [
      [4, 5]
    ]
  ]

The old logic treats this subview as contiguous, when it is not.

Diff Detail

Event Timeline

jreiffers created this revision.Sep 16 2022, 2:10 AM
jreiffers requested review of this revision.Sep 16 2022, 2:10 AM
ftynse accepted this revision.Sep 16 2022, 2:14 AM
This revision is now accepted and ready to land.Sep 16 2022, 2:14 AM
This revision was landed with ongoing or failed builds.Sep 16 2022, 2:32 AM
This revision was automatically updated to reflect the committed changes.