This is an archive of the discontinued LLVM Phabricator instance.

[libc++][format] Granularizes the format header.
ClosedPublic

Authored by Mordante on Sep 11 2022, 4:20 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG00798e500644: [libc++][format] Granularizes the format header.
Summary

Moves the last pieces of code to its own header.

Diff Detail

Event Timeline

Mordante created this revision.Sep 11 2022, 4:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2022, 4:20 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Mordante updated this revision to Diff 459354.Sep 11 2022, 4:46 AM

Fixes CI.

Mordante updated this revision to Diff 459371.Sep 11 2022, 7:55 AM

Attempts to fix the CI.

Mordante updated this revision to Diff 459379.Sep 11 2022, 9:21 AM

Attempts to fix the CI.

Mordante updated this revision to Diff 459477.Sep 12 2022, 8:55 AM

Attempts to fix CI.

ldionne added inline comments.
libcxx/include/__format/format_functions.h
797

This removal seems to be the issue on macOS backdeployment.

I think basically <format> never worked on back-deployment targets. We should look into this as a separate effort -- we shouldn't be getting compilation errors if we just try to include e.g. <chrono> with -fexperimental-library on a back-deployment target, which I think is probably the case right now. I think investigating this would be trying to remove this in run-buildbot:

# TODO: Enable experimental features during back-deployment -- right now some of the availability
#       annotations are incorrect, leading to test failures that could be avoided.
PARAMS+=";enable_experimental=False"
Mordante updated this revision to Diff 459794.Sep 13 2022, 10:19 AM

Attempts to fix CI based on observations while with @ldionne.

Mordante published this revision for review.Sep 14 2022, 11:03 PM
Mordante added a reviewer: ldionne.
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2022, 11:03 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Sep 20 2022, 9:24 AM
This revision is now accepted and ready to land.Sep 20 2022, 9:24 AM
This revision was landed with ongoing or failed builds.Sep 20 2022, 9:57 AM
This revision was automatically updated to reflect the committed changes.