This is an archive of the discontinued LLVM Phabricator instance.

[mlir] NFC - move declaration of `Range` to StaticValueUtils.h
ClosedPublic

Authored by christopherbate on Sep 8 2022, 2:01 PM.

Details

Summary

ViewLikeInterface.h defines a struct Range, and it also depends on
StaticValueUtils.h/cpp. This change moves the definition of Range to
StaticValueUtils.h, which should not violate any existing dependency
requirement. This is done to support adding utilities using Range
under Dialect/Utils without creating a circular dependency on
ViewLikeInterface. It is possible that some targets depend on
ViewLikeInterface just for the Range struct. These can be later
updated to depend on the MLIRDialectUtils target.

Diff Detail

Event Timeline

christopherbate created this revision.Sep 8 2022, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 2:01 PM
christopherbate requested review of this revision.Sep 8 2022, 2:01 PM

This is needed to address circular dependency blocking https://reviews.llvm.org/D129699.

nicolasvasilache accepted this revision.Sep 8 2022, 2:57 PM
This revision is now accepted and ready to land.Sep 8 2022, 2:57 PM