Page MenuHomePhabricator

One-shot-bufferize: fix for inconsistent while arg types in before/after.
ClosedPublic

Authored by jreiffers on Sep 8 2022, 12:39 AM.

Details

Summary

Currently, if the before and after regions of a while op have
tensor args in different indices, this leads to a crash.

This moves the pass-through check for args to the handling of the
condition block, since that is where the results are produced, so
it's also where copies must be made.

Diff Detail

Event Timeline

jreiffers created this revision.Sep 8 2022, 12:39 AM
jreiffers requested review of this revision.Sep 8 2022, 12:39 AM
springerm accepted this revision.Sep 8 2022, 12:40 AM

Nice cleanup, thanks!

This revision is now accepted and ready to land.Sep 8 2022, 12:40 AM
This revision was landed with ongoing or failed builds.Sep 8 2022, 1:24 AM
This revision was automatically updated to reflect the committed changes.