This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Shows the detailed compiler version info.
ClosedPublic

Authored by Mordante on Sep 1 2022, 9:40 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGc632ee1c5d65: [libc++] Shows the detailed compiler version info.
Summary

The libc++ pre-commit CI uses Clang nightly builds. Currently it's not
possible to determine the exact version used since CMake doesn't show
this information by default. Instead use the --version flag to get this
information.

Diff Detail

Event Timeline

Mordante created this revision.Sep 1 2022, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2022, 9:40 AM
Herald added a subscriber: mgorny. · View Herald Transcript
ldionne added a subscriber: ldionne.Sep 6 2022, 9:16 AM

IMO we should do this in run-buildbot instead. We can add this to the phase at the beginning where we output the --version of various tools (cmake, ninja, etc.). We should be able to use something like if [ ! -z "${CXX}" ]; then ${CXX} --version; fi.

Mordante updated this revision to Diff 459481.Sep 12 2022, 9:08 AM

Use @ldionne's suggested approach.

Mordante published this revision for review.Sep 12 2022, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 11:00 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Sep 13 2022, 8:54 AM
ldionne added inline comments.
libcxx/utils/ci/run-buildbot
150–153

IMO this comment doesn't pull its weight. It's useful to print the compiler version, no justification needed.

This revision is now accepted and ready to land.Sep 13 2022, 8:54 AM
Mordante marked an inline comment as done.Sep 16 2022, 7:15 AM
This revision was landed with ongoing or failed builds.Sep 16 2022, 7:15 AM
This revision was automatically updated to reflect the committed changes.