[llvm-gsymutil] Fix tracking of currently open file

[vikmik]

Summary

Prior to this change, CurrentGSYMPath was never updated. As a consequence, the GSYM file was reopened for every frame, even if all frames were relative to the same GSYM file.

This change brings a 13x speedup on a test I'm doing (symbolizing ~25K frames from libxul)

(This is my first-ever LLVM change - sorry if I missed something in the process!)

[vikmik]

This comment was removed by vikmik.

[clayborg]

I can't seem to accept this revision, but looks good to me.

[clayborg]

[vikmik]

In D132912#3759304, @clayborg wrote:

I can't seem to accept this revision, but looks good to me.

Oops. I hadn't used phabricator for 6 years - fixed! You should be able to accept now.
Thanks!

[simon.giesecke]

@vikmik Thanks a lot for fixing this!

[vikmik]

Thanks @clayborg & @simon.giesecke :)
I don't think I have access to push this myself to the main branch - is either of you able to do this? Thanks!

[smeenai]

What name and email would you like this committed under?

[vikmik]

@smeenai you can use "Victor Michel" / [redacted]@gmail.com

Thank you!

llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp

while (std::getline(std::cin, InputLine)) {
       StringRef AddrStr, GSYMPath;
       std::tie(AddrStr, GSYMPath) =
           llvm::StringRef{StrippedInputLine}.split(' ');
 
       if (GSYMPath != CurrentGSYMPath) {
         CurrentGsym = GsymReader::openFile(GSYMPath);
         if (!*CurrentGsym)
           error(GSYMPath, CurrentGsym->takeError());
+        CurrentGSYMPath = GSYMPath;
       }
 
       uint64_t Addr;
       if (AddrStr.getAsInteger(0, Addr)) {
         OS << "error: invalid address " << AddrStr
            << ", expected: Address GsymFile.\n";
         return 1;
       }