This is an archive of the discontinued LLVM Phabricator instance.

Fix bazel pre-merge check
AbandonedPublic

Authored by tpopp on Aug 29 2022, 11:10 AM.

Details

Diff Detail

Event Timeline

tpopp created this revision.Aug 29 2022, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 11:10 AM
tpopp requested review of this revision.Aug 29 2022, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 11:10 AM
tpopp updated this revision to Diff 456430.Aug 29 2022, 11:52 AM

linkopt can't be overriden with empty strings, so workaround differently.

tpopp updated this revision to Diff 456432.Aug 29 2022, 12:02 PM

Remove overlooked line.

tpopp updated this revision to Diff 456435.Aug 29 2022, 12:15 PM

Move flag from generic_clang to ci until pre-merge is fixed

tpopp updated this revision to Diff 456438.Aug 29 2022, 12:28 PM

Move fuse-ld to ci

GMNGeoffrey accepted this revision.Aug 29 2022, 12:31 PM

So the issue we're trying to solve is that the pre-merge check is still running on the old runners and using "--config=rbe", right? Please add that info to the description and link your PR (https://github.com/google/llvm-premerge-checks/pull/414) attempting to fix this in the pre-merge checks repo.

This revision is now accepted and ready to land.Aug 29 2022, 12:31 PM
aeubanks accepted this revision.Aug 29 2022, 12:47 PM
tpopp abandoned this revision.Aug 29 2022, 11:20 PM

Unfortunately, it looks like the version of clang on the pre-merge bazel build bot is too old, or similar, so I am abandoning this attempted workaround.