This is an archive of the discontinued LLVM Phabricator instance.

[libc] Implement linux link, linkat, symlink, symlinkat, readlink, readlinkat.
ClosedPublic

Authored by sivachandra on Aug 24 2022, 4:05 PM.

Diff Detail

Event Timeline

sivachandra created this revision.Aug 24 2022, 4:05 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 24 2022, 4:05 PM
sivachandra requested review of this revision.Aug 24 2022, 4:05 PM
michaelrj added inline comments.Aug 24 2022, 4:13 PM
libc/src/unistd/linux/readlink.cpp
26

should this be #elif defined(SYS_readlinkat)? If not, should the line above be #if SYS_readlink?

Fix preprocessor conitionals.

libc/src/unistd/linux/readlink.cpp
26

Uh, yes! If should be the former and I have fixed it now.

michaelrj accepted this revision.Aug 25 2022, 10:03 AM
This revision is now accepted and ready to land.Aug 25 2022, 10:03 AM