This was mentioned in review D131326.
Details
Details
- Reviewers
var-const philnik - Group Reviewers
Restricted Project - Commits
- rGa72f6b032c37: [libc++] Improves feature-test macro diagnostics.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for addressing this! I think this reads a lot better than the previous version. The double negation is still there, but it looks like it would require disproportional effort to get rid of that, and this looks like a very nice improvement.
libcxx/utils/generate_feature_test_macro_components.py | ||
---|---|---|
985 | Optional: do you think surrounding the expanded text with some symbol (e.g. quotes or backticks) will make the resulting string easier to read? E.g. (note the quotes): __cpp_lib_shared_mutex should not be defined when the requirement "!defined(_LIBCPP_HAS_NO_THREADS) && !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_shared_mutex)" is not met! |
Comment Actions
Thanks for the reviews!
libcxx/utils/generate_feature_test_macro_components.py | ||
---|---|---|
985 | Good suggestion: I will use the single quote to avoid escapes in the generated message. |
Optional: do you think surrounding the expanded text with some symbol (e.g. quotes or backticks) will make the resulting string easier to read? E.g. (note the quotes):