This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Fix incorrect pointer usage in Vulkan buffer and Memref descriptor binding
ClosedPublic

Authored by jackalcooper on Aug 20 2022, 5:28 AM.

Details

Summary

This should fix these issues:

  • Vulkan runtime will produce incorrect result if there is alignment.
  • There will be illegal memory access if binding a LLVM global materialized from a constant op (0xdeadbeef).

Diff Detail

Event Timeline

jackalcooper created this revision.Aug 20 2022, 5:28 AM
jackalcooper requested review of this revision.Aug 20 2022, 5:28 AM
antiagainst accepted this revision.Aug 22 2022, 3:12 PM

Thanks for fixing this!

This revision is now accepted and ready to land.Aug 22 2022, 3:12 PM
This revision was automatically updated to reflect the committed changes.