This is an archive of the discontinued LLVM Phabricator instance.

Differential D132153

[flang][runtime] Improve error message for incompatible MATMUL arguments
ClosedPublic

Authored by klausler on Aug 18 2022, 11:12 AM.

Details

Reviewers
vdonaldson
Commits
rGf5884fd9de6c: [flang][runtime] Improve error message for incompatible MATMUL arguments
Summary

Print the full shapes of both argument when the dimensions that must
match do not do so.

Diff Detail

Event Timeline

klausler created this revision.Aug 18 2022, 11:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2022, 11:12 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Aug 18 2022, 11:12 AM
vdonaldson accepted this revision.Aug 18 2022, 11:34 AM
This revision is now accepted and ready to land.Aug 18 2022, 11:34 AM
Harbormaster completed remote builds in B182043: Diff 453716.Aug 18 2022, 12:12 PM
Closed by commit rGf5884fd9de6c: [flang][runtime] Improve error message for incompatible MATMUL arguments (authored by klausler). · Explain WhyAug 18 2022, 1:59 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rGf5884fd9de6c: [flang][runtime] Improve error message for incompatible MATMUL arguments.

Revision Contents

PathSize
flang/
runtime/
6 lines

Diff 453716

flang/runtime/matmul.cpp

Context not available.
} }
SubscriptValue n{x.GetDimension(xRank - 1).Extent()}; SubscriptValue n{x.GetDimension(xRank - 1).Extent()};
if (n != y.GetDimension(0).Extent()) { if (n != y.GetDimension(0).Extent()) {
terminator.Crash("MATMUL: arrays do not conform (%jd != %jd)", terminator.Crash("MATMUL: unacceptable operand shapes (%jdx%jd, %jdx%jd)",
static_cast<std::intmax_t>(x.GetDimension(0).Extent()),
static_cast<std::intmax_t>(n), static_cast<std::intmax_t>(n),
static_cast<std::intmax_t>(y.GetDimension(0).Extent())); static_cast<std::intmax_t>(y.GetDimension(0).Extent()),
static_cast<std::intmax_t>(y.GetDimension(1).Extent()));
} }
using WriteResult = using WriteResult =
CppTypeFor<RCAT == TypeCategory::Logical ? TypeCategory::Integer : RCAT, CppTypeFor<RCAT == TypeCategory::Logical ? TypeCategory::Integer : RCAT,
Context not available.