This is an archive of the discontinued LLVM Phabricator instance.

Differential D132007

[NFC][M68k][test] Fix incorrect use of `getelementptr`
ClosedPublic

Authored by 0x59616e on Aug 16 2022, 8:44 PM.

Details

Reviewers
myhsu
RKSimon
Commits
rG721a128bb365: [NFC][M68k][test] Fix incorrect use of `getelementptr`
Summary

It turns out that issue #56990 is caused by the misuse of getelementptr in link-unlnk.ll.

Diff Detail

Event Timeline

0x59616e created this revision.Aug 16 2022, 8:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 8:44 PM
0x59616e requested review of this revision.Aug 16 2022, 8:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 8:44 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B181675: Diff 453192.Aug 16 2022, 9:13 PM
RKSimon added a comment.Aug 18 2022, 4:50 AM

Maybe add useful test coverage for gep [8 x i32] as well?

0x59616e updated this revision to Diff 454379.Aug 21 2022, 10:04 PM

update diff: add test for getelementptr

0x59616e updated this revision to Diff 454383.Aug 21 2022, 10:08 PM

re-update diff

RKSimon accepted this revision.Aug 22 2022, 12:01 AM

LGTM

This revision is now accepted and ready to land.Aug 22 2022, 12:01 AM
Harbormaster completed remote builds in B182506: Diff 454383.Aug 22 2022, 12:08 AM
0x59616e added a comment.Aug 25 2022, 11:40 PM

Thanks !

Closed by commit rG721a128bb365: [NFC][M68k][test] Fix incorrect use of `getelementptr` (authored by 0x59616e). · Explain WhyAug 25 2022, 11:43 PM
This revision was automatically updated to reflect the committed changes.
0x59616e added a commit: rG721a128bb365: [NFC][M68k][test] Fix incorrect use of `getelementptr`.

Revision Contents

PathSize
llvm/
test/
CodeGen/
M68k/
81 lines

Diff 455806

llvm/test/CodeGen/M68k/link-unlnk.ll

Show All 11 Lines
; FP-NEXT: link.w %a6, #-32 ; FP-NEXT: link.w %a6, #-32
; FP-NEXT: .cfi_def_cfa_offset -8 ; FP-NEXT: .cfi_def_cfa_offset -8
; FP-NEXT: .cfi_offset %a6, -8 ; FP-NEXT: .cfi_offset %a6, -8
; FP-NEXT: .cfi_def_cfa_register %a6 ; FP-NEXT: .cfi_def_cfa_register %a6
; FP-NEXT: move.l (8,%a6), %d1 ; FP-NEXT: move.l (8,%a6), %d1
; FP-NEXT: move.l %d1, (-32,%a6) ; FP-NEXT: move.l %d1, (-32,%a6)
; FP-NEXT: move.l (12,%a6), %d0 ; FP-NEXT: move.l (12,%a6), %d0
; FP-NEXT: add.l %d0, %d1 ; FP-NEXT: add.l %d0, %d1
; FP-NEXT: move.l %d0, (0,%a6) ; FP-NEXT: move.l %d0, (-28,%a6)
; FP-NEXT: add.l %d1, %d0 ; FP-NEXT: add.l %d1, %d0
; FP-NEXT: move.l %d1, (32,%a6) ; FP-NEXT: move.l %d1, (-24,%a6)
; FP-NEXT: add.l %d0, %d1 ; FP-NEXT: add.l %d0, %d1
; FP-NEXT: move.l %d0, (64,%a6) ; FP-NEXT: move.l %d0, (-20,%a6)
; FP-NEXT: move.l %d1, (96,%a6) ; FP-NEXT: move.l %d1, (-16,%a6)
; FP-NEXT: add.l %d1, %d0 ; FP-NEXT: add.l %d1, %d0
; FP-NEXT: move.l %d0, (128,%a6) ; FP-NEXT: move.l %d0, (-12,%a6)
; FP-NEXT: add.l %d0, %d1 ; FP-NEXT: add.l %d0, %d1
; FP-NEXT: move.l %d1, (160,%a6) ; FP-NEXT: move.l %d1, (-8,%a6)
; FP-NEXT: add.l %d1, %d0 ; FP-NEXT: add.l %d1, %d0
; FP-NEXT: move.l %d0, (192,%a6) ; FP-NEXT: move.l %d0, (-4,%a6)
; FP-NEXT: unlk %a6 ; FP-NEXT: unlk %a6
; FP-NEXT: rts ; FP-NEXT: rts
; ;
; NO-FP-LABEL: fib: ; NO-FP-LABEL: fib:
; NO-FP: .cfi_startproc ; NO-FP: .cfi_startproc
; NO-FP-NEXT: ; %bb.0: ; %entry ; NO-FP-NEXT: ; %bb.0: ; %entry
; NO-FP-NEXT: suba.l #32, %sp ; NO-FP-NEXT: suba.l #32, %sp
; NO-FP-NEXT: .cfi_def_cfa_offset -36 ; NO-FP-NEXT: .cfi_def_cfa_offset -36
; NO-FP-NEXT: move.l (36,%sp), %d1 ; NO-FP-NEXT: move.l (36,%sp), %d1
; NO-FP-NEXT: move.l %d1, (0,%sp) ; NO-FP-NEXT: move.l %d1, (0,%sp)
; NO-FP-NEXT: move.l (40,%sp), %d0 ; NO-FP-NEXT: move.l (40,%sp), %d0
; NO-FP-NEXT: add.l %d0, %d1 ; NO-FP-NEXT: add.l %d0, %d1
; NO-FP-NEXT: move.l %d0, (32,%sp) ; NO-FP-NEXT: move.l %d0, (4,%sp)
; NO-FP-NEXT: add.l %d1, %d0 ; NO-FP-NEXT: add.l %d1, %d0
; NO-FP-NEXT: move.l %d1, (64,%sp) ; NO-FP-NEXT: move.l %d1, (8,%sp)
; NO-FP-NEXT: add.l %d0, %d1 ; NO-FP-NEXT: add.l %d0, %d1
; NO-FP-NEXT: move.l %d0, (96,%sp) ; NO-FP-NEXT: move.l %d0, (12,%sp)
; NO-FP-NEXT: move.l %d1, (128,%sp) ; NO-FP-NEXT: move.l %d1, (16,%sp)
; NO-FP-NEXT: add.l %d1, %d0 ; NO-FP-NEXT: add.l %d1, %d0
; NO-FP-NEXT: move.l %d0, (160,%sp) ; NO-FP-NEXT: move.l %d0, (20,%sp)
; NO-FP-NEXT: add.l %d0, %d1 ; NO-FP-NEXT: add.l %d0, %d1
; NO-FP-NEXT: move.l %d1, (192,%sp) ; NO-FP-NEXT: move.l %d1, (24,%sp)
; NO-FP-NEXT: add.l %d1, %d0 ; NO-FP-NEXT: add.l %d1, %d0
; NO-FP-NEXT: move.l %d0, (224,%sp) ; NO-FP-NEXT: move.l %d0, (28,%sp)
; NO-FP-NEXT: adda.l #32, %sp ; NO-FP-NEXT: adda.l #32, %sp
; NO-FP-NEXT: rts ; NO-FP-NEXT: rts
entry: entry:
%arr = alloca [8 x i32], align 4 %arr = alloca [8 x i32], align 4
%s0 = getelementptr [8 x i32], ptr %arr, i32 0 %s0 = getelementptr i32, ptr %arr, i32 0
%s1 = getelementptr [8 x i32], ptr %arr, i32 1 %s1 = getelementptr i32, ptr %arr, i32 1
store i32 %a, i32* %s0 store i32 %a, i32* %s0
store i32 %b, i32* %s1 store i32 %b, i32* %s1
%ptr0 = getelementptr [8 x i32], ptr %arr, i32 0 %ptr0 = getelementptr i32, ptr %arr, i32 0
%ptr1 = getelementptr [8 x i32], ptr %arr, i32 1 %ptr1 = getelementptr i32, ptr %arr, i32 1
%ptr2 = getelementptr [8 x i32], ptr %arr, i32 2 %ptr2 = getelementptr i32, ptr %arr, i32 2
%ptr3 = getelementptr [8 x i32], ptr %arr, i32 3 %ptr3 = getelementptr i32, ptr %arr, i32 3
%ptr4 = getelementptr [8 x i32], ptr %arr, i32 4 %ptr4 = getelementptr i32, ptr %arr, i32 4
%ptr5 = getelementptr [8 x i32], ptr %arr, i32 5 %ptr5 = getelementptr i32, ptr %arr, i32 5
%ptr6 = getelementptr [8 x i32], ptr %arr, i32 6 %ptr6 = getelementptr i32, ptr %arr, i32 6
%ptr7 = getelementptr [8 x i32], ptr %arr, i32 7 %ptr7 = getelementptr i32, ptr %arr, i32 7
%res0 = load i32, i32 * %ptr0 %res0 = load i32, i32 * %ptr0
%res1 = load i32, i32 * %ptr1 %res1 = load i32, i32 * %ptr1
%res2 = add i32 %res0, %res1 %res2 = add i32 %res0, %res1
store i32 %res2, i32 * %ptr2 store i32 %res2, i32 * %ptr2
%res3 = add i32 %res1, %res2 %res3 = add i32 %res1, %res2
store i32 %res3, i32 * %ptr3 store i32 %res3, i32 * %ptr3
%res4 = add i32 %res2, %res3 %res4 = add i32 %res2, %res3
store i32 %res4, i32 * %ptr4 store i32 %res4, i32 * %ptr4
%res5 = add i32 %res3, %res4 %res5 = add i32 %res3, %res4
store i32 %res5, i32 * %ptr5 store i32 %res5, i32 * %ptr5
%res6 = add i32 %res4, %res5 %res6 = add i32 %res4, %res5
store i32 %res6, i32 * %ptr6 store i32 %res6, i32 * %ptr6
%res7 = add i32 %res5, %res6 %res7 = add i32 %res5, %res6
store i32 %res7, i32 * %ptr7 store i32 %res7, i32 * %ptr7
ret i32 %res7 ret i32 %res7
} }
define i32 @test_gep() {
; FP-LABEL: test_gep:
; FP: .cfi_startproc
; FP-NEXT: ; %bb.0: ; %entry
; FP-NEXT: link.w %a6, #-256
; FP-NEXT: .cfi_def_cfa_offset -8
; FP-NEXT: .cfi_offset %a6, -8
; FP-NEXT: .cfi_def_cfa_register %a6
; FP-NEXT: move.l #21, (-4,%a6)
; FP-NEXT: move.l #12, (-256,%a6)
; FP-NEXT: move.l #0, %d0
; FP-NEXT: unlk %a6
; FP-NEXT: rts
;
; NO-FP-LABEL: test_gep:
; NO-FP: .cfi_startproc
; NO-FP-NEXT: ; %bb.0: ; %entry
; NO-FP-NEXT: suba.l #256, %sp
; NO-FP-NEXT: .cfi_def_cfa_offset -260
; NO-FP-NEXT: move.l #21, (252,%sp)
; NO-FP-NEXT: move.l #12, (0,%sp)
; NO-FP-NEXT: move.l #0, %d0
; NO-FP-NEXT: adda.l #256, %sp
; NO-FP-NEXT: rts
entry:
%arr = alloca [8 x [8 x i32]]
%ptr1 = getelementptr [8 x i32], ptr %arr, i64 0, i64 0
store i32 12, i32 * %ptr1
%ptr2 = getelementptr [8 x i32], ptr %arr, i64 7, i64 7
store i32 21, i32 * %ptr2
ret i32 0
}