This is an archive of the discontinued LLVM Phabricator instance.

[mlir][bufferize] Fix bug in AllocTensorElimination
ClosedPublic

Authored by springerm on Aug 15 2022, 2:15 AM.

Details

Summary

IR with tensor type changes is not supported yet.

Diff Detail

Event Timeline

springerm created this revision.Aug 15 2022, 2:15 AM
springerm requested review of this revision.Aug 15 2022, 2:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2022, 2:15 AM
nicolasvasilache accepted this revision.Aug 15 2022, 2:40 AM

Please beef up the commit message a bit using the same rationale as the comment in your test:

// AllocTensorElimination does currently not apply to chains where the type is
// changing. This test just ensures that we do not crash or generate IR that
// does not verify.
This revision is now accepted and ready to land.Aug 15 2022, 2:40 AM
This revision was automatically updated to reflect the committed changes.