This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Use noexcept instead of the macros where possible
AbandonedPublic

Authored by philnik on Aug 14 2022, 3:28 AM.

Details

Reviewers
ldionne
Mordante
var-const
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

philnik created this revision.Aug 14 2022, 3:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2022, 3:28 AM
philnik requested review of this revision.Aug 14 2022, 3:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2022, 3:28 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

I'm not really convinced this patch is really worth the effort, but no real objections.

libcxx/include/__algorithm/iter_swap.h
25

This is correct, but I find it confusion. In this case I would really prefer to use the macro twice.

I see we already use this in some places, but to me this change isn't an improvement.

libcxx/include/__memory/shared_ptr.h
1764

How did you detect these places to adjust? It seems there are more places.

libcxx/include/string
1745

This one can be changed too.

philnik abandoned this revision.Sep 21 2023, 1:45 AM