Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
I'm not really convinced this patch is really worth the effort, but no real objections.
libcxx/include/__algorithm/iter_swap.h | ||
---|---|---|
25 | This is correct, but I find it confusion. In this case I would really prefer to use the macro twice. I see we already use this in some places, but to me this change isn't an improvement. | |
libcxx/include/__memory/shared_ptr.h | ||
1764 | How did you detect these places to adjust? It seems there are more places. | |
libcxx/include/string | ||
1745 | This one can be changed too. |
This is correct, but I find it confusion. In this case I would really prefer to use the macro twice.
I see we already use this in some places, but to me this change isn't an improvement.